Skip to content
This repository was archived by the owner on Oct 20, 2020. It is now read-only.
This repository was archived by the owner on Oct 20, 2020. It is now read-only.

MySmallPhpTools dependency #59

@ChinaShrimp

Description

@ChinaShrimp

I'm using NC 18.0 and dashboard app (source code, not published in app store). After installing the built dashboard to apps directory, nextcloud starts with complaining logs:

[Tue Jan 21 11:57:10 2020] PHP Fatal error:  Trait 'daita\MySmallPhpTools\Traits\TArrayTools' not found in /Users/lyon/workspace/nextcloud/server/apps/dashboard/lib/Service/WidgetsService.php on line 49
[Tue Jan 21 11:57:10 2020] ::1:56602 [500]: /index.php/apps/files/ - Trait 'daita\MySmallPhpTools\Traits\TArrayTools' not found in /Users/lyon/workspace/nextcloud/server/apps/dashboard/lib/Service/WidgetsService.php on line 49
[Tue Jan 21 11:57:10 2020] Trait 'daita\MySmallPhpTools\Traits\TArrayTools' not found at /Users/lyon/workspace/nextcloud/server/apps/dashboard/lib/Service/WidgetsService.php#49

Reproduce steps:

  1. Setup nextcloud 18.0;
  2. git clone dashboard app and run 'make all' under dashboard app root directory;
  3. copy built artifact dashboard-6.0.0.tar.gz to nextcloud apps directory, untar it and rename the app directory name to dashboard;
  4. restart nextcloud;

From my view, this problem is caused by lacking of dependency of 3rd party lib(MySmallPhpTools), and I turned to Makefile:

appstore: composer npm clean
	mkdir -p $(sign_dir)
	rsync -a \
	--exclude=/build \
	--exclude=/docs \
	--exclude=/l10n/templates \
	--exclude=/l10n/.tx \

Before zipping the app, vendor directory is deleted due to clean task in the Makefile.

So I removed 'clean' for appstore task and nextcloud starts successfully without above complaining logs.

I'm not sure whether this modification is right, and need your help. Thanks!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions