Skip to content

fix(AppImage): include an extra library for nss3 to prevent a crash #9171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mgallien merged 1 commit into from
Dec 4, 2025
Merged

fix(AppImage): include an extra library for nss3 to prevent a crash #9171

mgallien merged 1 commit into from
Dec 4, 2025
+1 −1

Conversation

@mgallien
Copy link
Collaborator

@mgallien mgallien commented Dec 3, 2025

No description provided.

@mgallien mgallien force-pushed the bugfix/addMissingLibrayInAppImage branch from 4e2e25a to 33f9d66 Compare December 3, 2025 13:17
@mgallien mgallien added this to the 4.1.0 milestone Dec 3, 2025
@mgallien
Copy link
Collaborator Author

mgallien commented Dec 3, 2025

/backport to stable-3.17

@mgallien
Copy link
Collaborator Author

mgallien commented Dec 3, 2025

/backport to stable-4.0

@mgallien mgallien enabled auto-merge December 3, 2025 14:05
@mgallien mgallien force-pushed the bugfix/addMissingLibrayInAppImage branch from 33f9d66 to 2442e50 Compare December 3, 2025 14:05
@maximelehericy
Copy link

maximelehericy commented Dec 4, 2025 •
edited
Loading

Tested successfully on the first attempt: no more crash, and the authentication goes to the end. Note: all the authentication happens within the client (the browser is never launched nor used)

However, on the second (and further) attempt, the behavior changes consistently: the client launches the browser, and after authentication, it is a failure: state token do not match.

See screenshots:
Screenshot From 2025-12-04 10-28-53
Screenshot From 2025-12-04 10-29-43

To sort of reset the behavior, I need to exit the desktop client, close all browser window, and start again the client.

@mgallien mgallien force-pushed the bugfix/addMissingLibrayInAppImage branch from 2442e50 to 21edd08 Compare December 4, 2025 15:03
@github-actions
Copy link

github-actions bot commented Dec 4, 2025

Artifact containing the AppImage: nextcloud-appimage-pr-9171.zip

Digest: sha256:18431c9b276cd7a7b2c2582e8614d9c05b25bfcbe7d055c6fcb06f6301b5d1a5

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

@mgallien mgallien merged commit a95d686 into master Dec 4, 2025
20 checks passed
@mgallien mgallien deleted the bugfix/addMissingLibrayInAppImage branch December 4, 2025 15:52
This was referenced Dec 4, 2025
Merged
Merged
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 4, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nilsding nilsding nilsding approved these changes

@Aiiaiiio Aiiaiiio Awaiting requested review from Aiiaiiio Aiiaiiio is a code owner

@camilasan camilasan Awaiting requested review from camilasan camilasan is a code owner

@i2h3 i2h3 Awaiting requested review from i2h3 i2h3 is a code owner

Assignees

No one assigned

Labels

3. to review

Projects

None yet

Milestone

4.1.0

Development

Successfully merging this pull request may close these issues.

4 participants

@mgallien @maximelehericy @nilsding