Fix ncpweb performance #2054
Closed
Fix ncpweb performance #2054
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and may need lots of optimization. Also, it introduces web UI quirks which should be corrected anyhow. For example: The nc-webui sidebar has a tick slowly acquired by exec nc-webui.sh which queries if the Apache2 NCP cfg is active. This should be queried during install or updates and put in nc-webui.cfg ACTIVE=true instead of slow runtime grok.
TobiGr
reviewed
Nov 13, 2025
| trap 'cd /; rm -rf "${TEMPDIR}"' EXIT | ||
|
|
||
| echo -e "Downloading updates" | ||
| git clone --depth 20 -b "$BRANCH" -q https://github.com/nextcloud/nextcloudpi.git "$TEMPDIR" || { |
Author
There was a problem hiding this comment.
Thanks for the reminder. I was not aware that I was still working on the PullRQ-ed branch. The above change was not meant to be pulled in here. Also, Github complains about signed-offs, thus I will cancel the request.
Author
|
This pretty old and I don't think it's helpful any more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The https://localhost:4443 is very slow on a PI. Main reason is the very slow jq-1.6 on recent Armbians that is executed several times when "source etc/library.sh". One can generally install a faster alternative (see https://github.com/01mf02/jaq) but also this MR implements some fast caching for CPU hogging lines in library.sh