fix: add INodeByPath to Directory [wip]

Signed-off-by: Salvatore Martire <[email protected]>

Author: salmart-dev

apps/dav/lib/Connector/Sabre/Directory.php

@@ -8,6 +8,7 @@
 namespace OCA\DAV\Connector\Sabre;
 
 use OC\Files\Mount\MoveableMount;
+use OC\Files\Utils\PathHelper;
 use OC\Files\View;
 use OCA\DAV\AppInfo\Application;
 use OCA\DAV\Connector\Sabre\Exception\FileLocked;
@@ -38,8 +39,14 @@
 use Sabre\DAV\Exception\ServiceUnavailable;
 use Sabre\DAV\IFile;
 use Sabre\DAV\INode;
-
-class Directory extends Node implements \Sabre\DAV\ICollection, \Sabre\DAV\IQuota, \Sabre\DAV\IMoveTarget, \Sabre\DAV\ICopyTarget {
+use Sabre\DAV\INodeByPath;
+
+class Directory extends Node implements
+	\Sabre\DAV\ICollection,
+	\Sabre\DAV\IQuota,
+	\Sabre\DAV\IMoveTarget,
+	\Sabre\DAV\ICopyTarget,
+	INodeByPath {
 	/**
 	 * Cached directory content
 	 * @var FileInfo[]
@@ -490,4 +497,83 @@ public function copyInto($targetName, $sourcePath, INode $sourceNode) {
 	public function getNode(): Folder {
 		return $this->node;
 	}
+
+	public function getNodeForPath($path): INode {
+		$storage = $this->info->getStorage();
+		$allowDirectory = false;
+
+		// Checking if we're in a file drop
+		// If we are, then only PUT and MKCOL are allowed (see plugin)
+		// so we are safe to return the directory without a risk of
+		// leaking files and folders structure.
+		if ($storage->instanceOfStorage(PublicShareWrapper::class)) {
+			$share = $storage->getShare();
+			$allowDirectory = ($share->getPermissions() & Constants::PERMISSION_READ) !== Constants::PERMISSION_READ;
+		}
+
+		// For file drop we need to be allowed to read the directory with the nickname
+		if (!$allowDirectory && !$this->info->isReadable()) {
+			// avoid detecting files through this way
+			throw new NotFound();
+		}
+
+		$destinationPath = $this->getPath() . '/' . $path;
+		$destinationDir = $this->getPath();
+		$destinationName = basename($destinationPath);
+
+		try {
+			$this->fileView->verifyPath($destinationDir, $destinationName, true);
+			$info = $this->fileView->getFileInfo($destinationPath);
+		} catch (StorageNotAvailableException $e) {
+			throw new \Sabre\DAV\Exception\ServiceUnavailable($e->getMessage(), 0, $e);
+		} catch (InvalidPathException $ex) {
+			throw new InvalidPath($ex->getMessage(), false, $ex);
+		} catch (ForbiddenException $e) {
+			throw new \Sabre\DAV\Exception\Forbidden($e->getMessage(), $e->getCode(), $e);
+		}
+
+		if (!$info) {
+			throw new \Sabre\DAV\Exception\NotFound('File with name ' . $fullPath
+				. ' could not be located');
+		}
+
+		// if not in a public share with no read permissions, throw Forbidden
+		if (!$allowDirectory && !$info->isReadable()) {
+			if (Server::get(IAppManager::class)->isEnabledForAnyone('files_accesscontrol')) {
+				throw new Forbidden('No read permissions. This might be caused by files_accesscontrol, check your configured rules');
+			}
+
+			throw new Forbidden('No read permissions');
+		}
+
+		if ($info->getMimeType() === FileInfo::MIMETYPE_FOLDER) {
+			$node = new \OCA\DAV\Connector\Sabre\Directory($this->fileView, $info, $this->tree, $this->shareManager);
+		} else {
+			// In case reading a directory was allowed but it turns out the node was a not a directory, reject it now.
+			if (!$this->info->isReadable()) {
+				throw new NotFound();
+			}
+
+			$node = new File($this->fileView, $info, $this->shareManager);
+		}
+		$this->tree?->cacheNode($node);
+
+		// recurse upwards until the root (for backwards-compatibility)
+		// no need to get child information
+		if ($destinationDir !== '') {
+			/** @var Folder $scanNode */
+			$scanNode = $node->getNode();
+			$scanPath = $destinationName;
+			while ($parent = $scanNode->getParent()) {
+				$parent->get($scanPath);
+				$scanPath = $parent->getName();
+				if ($scanPath === '') {
+					break;
+				}
+				$scanNode = $parent;
+			}
+		}
+
+		return $node;
+	}
 }