Path specific Filesystem setup

[salmart-dev]

• Resolves: Path specific file sytem setup #54562

Summary

This branch introduces WIP changes to setupForPath to implement a version taking advantage of the authoritative mount point list.

The branch is part of this set of branches:

• master
  • Refactor mount providers files_sharing app #56537
    • Add INodeByPath to Directory #54441
      • Path specific Filesystem setup #55072 👈
        • Implement path-based FS Setup in server MountProviders #56538

TODO

• Check if we ship without the changes for the INodeByPath implementation

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[github-actions]

Possible performance regression detected

Show Output

An unhandled exception has been thrown:
TypeError: array_map(): Argument #2 ($array) must be of type array, null given in /home/runner/work/server/server/apps/profiler/lib/Command/Compare.php:35
Stack trace:
#0 /home/runner/work/server/server/apps/profiler/lib/Command/Compare.php(35): array_map()
#1 /home/runner/work/server/server/3rdparty/symfony/console/Command/Command.php(326): OCAProfilerCommandCompare->execute()
#2 /home/runner/work/server/server/core/Command/Base.php(218): SymfonyComponentConsoleCommandCommand->run()
#3 /home/runner/work/server/server/3rdparty/symfony/console/Application.php(1078): OCCoreCommandBase->run()
#4 /home/runner/work/server/server/3rdparty/symfony/console/Application.php(324): SymfonyComponentConsoleApplication->doRunCommand()
#5 /home/runner/work/server/server/3rdparty/symfony/console/Application.php(175): SymfonyComponentConsoleApplication->doRun()
#6 /home/runner/work/server/server/lib/private/Console/Application.php(187): SymfonyComponentConsoleApplication->run()
#7 /home/runner/work/server/server/console.php(91): OCConsoleApplication->run()
#8 /home/runner/work/server/server/occ(33): require_once('...')
#9 {main}

[icewind1991]

I would suggest adding a data class (something like IMountProviderArgs) that has the ICachedMountInfo, ICacheEntry and mountpoint and pass an array of that. So we have a stricter relationship between the various parts.

[icewind1991]

@return array<string, IMountPount> and requiring them to be indexed by mountpoint will probably prove useful

[icewind1991]

is this related?

[salmart-dev]

No just a temp change to allow outputting query logs when the file is writable but the parent directory is not. It's gone.

[icewind1991]

this will also need it's own migration for existing instances

[salmart-dev]

Yep, my current problem is how to fill the column 😮‍💨

I was thinking we could populate it when we add or update entries in oc_mounts since at that moment we build a list of all available mounts (although this won't work for long if we need to split) but I ran into a few issues:

• currently we don't use the id column from oc_mounts at all, so it needs to be exposed
• the fact we wrap IMountPoints in cache entries gets in the way and I didn't manage to find a way to reliably transport the parent id into the db. I'll need to give it another try.