fix: add unit tests

Author: alexcotelin

projects/ngneat/forms-manager/src/lib/forms-manager.spec.ts

@@ -1240,4 +1240,46 @@ describe('FormsManager', () => {
       expect(formsManager.getInitialValue('other')).toBeUndefined();
     });
   });
+
+  describe('Debounce', () => {
+    it('should update value after default debounce of 300ms for update on change controls', fakeAsync(() => {
+      const updateOnChangeGroup = new FormGroup({
+        name: new FormControl(null, { updateOn: 'change' }),
+      });
+      formsManager.upsert('updateOnChangeGroup', updateOnChangeGroup);
+
+      updateOnChangeGroup.get('name').patchValue('Smith');
+
+      tick(100);
+      expect(formsManager.getControl('updateOnChangeGroup', 'name').value).toEqual(null);
+
+      tick(301);
+      expect(formsManager.getControl('updateOnChangeGroup', 'name').value).toEqual('Smith');
+    }));
+
+    it('should skip debounce and update value immediately for a form group set to update on blur', () => {
+      const updateOnBlurGroup = new FormGroup(
+        {
+          name: new FormControl(),
+        },
+        { updateOn: 'blur' }
+      );
+      formsManager.upsert('updateOnBlurGroup', updateOnBlurGroup);
+
+      updateOnBlurGroup.get('name').patchValue('Smith');
+
+      expect(formsManager.getControl('updateOnBlurGroup', 'name').value).toEqual('Smith');
+    });
+
+    it('should skip debounce and update value immediately for a form control set to update on blur', () => {
+      const updateOnBlurGroup = new FormGroup({
+        name: new FormControl(null, { updateOn: 'blur' }),
+      });
+      formsManager.upsert('updateOnBlurGroup', updateOnBlurGroup);
+
+      updateOnBlurGroup.get('name').patchValue('Smith');
+
+      expect(formsManager.getControl('updateOnBlurGroup', 'name').value).toEqual('Smith');
+    });
+  });
 });

projects/ngneat/forms-manager/src/lib/forms-manager.ts

@@ -9,7 +9,7 @@ import { Config, NG_FORMS_MANAGER_CONFIG, NgFormsManagerConfig } from './config'
 import { isEqual } from './isEqual';
 import { deleteControl, findControl, handleFormArray, toStore } from './builders';
 
-const NO_DEBOUNCE = 0;
+const NO_DEBOUNCE = Symbol('NO_DEBOUNCE');
 
 @Injectable({ providedIn: 'root' })
 export class NgFormsManager<FormsState = any> {
@@ -401,7 +401,10 @@ export class NgFormsManager<FormsState = any> {
 
       if (control instanceof FormGroup) {
         return Object.keys(control.controls).reduce(
-          (previous, key) => [...previous, control.get(key).valueChanges.pipe(mapTo(NO_DEBOUNCE))],
+          (previous, key) =>
+            control.get(key).updateOn === 'blur'
+              ? [...previous, control.get(key).valueChanges.pipe(mapTo(NO_DEBOUNCE))]
+              : [...previous],
           streams
         );
       }