fs: fix incorrect dereferencing of src arg in cpSync

Author: npaun

src/node_file.cc

@@ -3210,8 +3210,8 @@ static void CpSyncCheckPaths(const FunctionCallbackInfo<Value>& args) {
 
   std::error_code error_code;
   auto src_status = dereference
-                        ? std::filesystem::symlink_status(src_path, error_code)
-                        : std::filesystem::status(src_path, error_code);
+                        ? std::filesystem::status(src_path, error_code)
+                        : std::filesystem::symlink_status(src_path, error_code);
 
   if (error_code) {
 #ifdef _WIN32

test/parallel/test-fs-cp-sync-dereference.js renamed to test/parallel/test-fs-cp-sync-dereference-false.js

@@ -0,0 +1,46 @@
+'use strict';
+
+// Refs: https://github.com/nodejs/node/issues/58939
+//
+// In this test, both the cp and cpSync functions are attempting to copy
+// a file over a symlinked directory.
+
+const common = require('../common');
+
+const {
+  cp,
+  cpSync,
+  mkdirSync,
+  symlinkSync,
+  writeFileSync,
+  readFileSync,
+  statSync,
+  lstatSync,
+} = require('fs');
+
+const {
+  join,
+} = require('path');
+
+const assert = require('assert');
+
+const tmpdir = require('../common/tmpdir');
+tmpdir.refresh();
+
+const pathA = join(tmpdir.path, 'a');
+const pathB = join(tmpdir.path, 'b');
+const pathC = join(tmpdir.path, 'c');
+const pathD = join(tmpdir.path, 'd');
+const pathDC = join(pathD, 'c');
+
+writeFileSync(pathA, 'file a');
+assert.ok(statSync(pathA).isFile());
+symlinkSync(pathA, pathC); // c -> a
+assert.ok(lstatSync(pathC).isSymbolicLink());
+assert.ok(statSync(pathC).isFile());
+
+cpSync(pathC, pathD, {dereference: true});
+// d/c -> a
+// d/c
+assert.ok(statSync(pathD).isFile());
+assert.strictEqual(readFileSync(pathD, 'utf8'), 'file a');