test: ensure assertions are reached on more tests

PR-URL: #60761
Reviewed-By: Colin Ihrig <[email protected]>

Author: aduh95

test/eslint.config_partial.mjs

@@ -195,7 +195,7 @@ export default [
       `test/parallel/test-{${
         // 0x61 is code for 'a', this generates a string enumerating latin letters: 'a*,b*,…'
         Array.from({ length: 13 }, (_, i) => String.fromCharCode(0x61 + i, 42)).join(',')
-      },${
+      },n*,${
         // 0x61 is code for 'a', this generates a string enumerating latin letters: 'z*,y*,…'
         Array.from({ length: 8 }, (_, i) => String.fromCharCode(0x61 + 25 - i, 42)).join(',')
       }}.{js,mjs,cjs}`,

test/parallel/test-navigator.js

@@ -36,10 +36,10 @@ const { getNavigatorPlatform } = require('internal/navigator');
 const { execFile } = require('child_process');
 
 const is = {
-  number: (value, key) => {
+  number: common.mustCallAtLeast((value, key) => {
     assert(!Number.isNaN(value), `${key} should not be NaN`);
     assert.strictEqual(typeof value, 'number');
-  },
+  }),
 };
 
 is.number(+navigator.hardwareConcurrency, 'hardwareConcurrency');

test/parallel/test-net-autoselectfamily-commandline-option.js

@@ -10,12 +10,12 @@ const { createConnection, createServer } = require('net');
 
 // Test that IPV4 is NOT reached if IPV6 is not reachable and the option has been disabled via command line
 {
-  const ipv4Server = createServer((socket) => {
+  const ipv4Server = createServer(common.mustCallAtLeast((socket) => {
     socket.on('data', common.mustCall(() => {
       socket.write('response-ipv4');
       socket.end();
     }));
-  });
+  }, 0));
 
   ipv4Server.listen(0, '127.0.0.1', common.mustCall(() => {
     const port = ipv4Server.address().port;

test/parallel/test-net-autoselectfamily-default.js

@@ -10,12 +10,12 @@ const autoSelectFamilyAttemptTimeout = common.defaultAutoSelectFamilyAttemptTime
 
 // Test that IPV4 is reached by default if IPV6 is not reachable and the default is enabled
 {
-  const ipv4Server = createServer((socket) => {
+  const ipv4Server = createServer(common.mustCall((socket) => {
     socket.on('data', common.mustCall(() => {
       socket.write('response-ipv4');
       socket.end();
     }));
-  });
+  }));
 
   ipv4Server.listen(0, '127.0.0.1', common.mustCall(() => {
     setDefaultAutoSelectFamily(true);
@@ -45,12 +45,12 @@ const autoSelectFamilyAttemptTimeout = common.defaultAutoSelectFamilyAttemptTime
 
 // Test that IPV4 is not reached by default if IPV6 is not reachable and the default is disabled
 {
-  const ipv4Server = createServer((socket) => {
+  const ipv4Server = createServer(common.mustCallAtLeast((socket) => {
     socket.on('data', common.mustCall(() => {
       socket.write('response-ipv4');
       socket.end();
     }));
-  });
+  }, 0));
 
   ipv4Server.listen(0, '127.0.0.1', common.mustCall(() => {
     setDefaultAutoSelectFamily(false);

test/parallel/test-net-autoselectfamily-ipv4first.js

@@ -8,12 +8,12 @@ const { createConnection, createServer } = require('net');
 
 // Test that happy eyeballs algorithm is properly implemented when a A record is returned first.
 if (common.hasIPv6) {
-  const ipv4Server = createServer((socket) => {
+  const ipv4Server = createServer(common.mustCall((socket) => {
     socket.on('data', common.mustCall(() => {
       socket.write('response-ipv4');
       socket.end();
     }));
-  });
+  }));
 
   const ipv6Server = createServer((socket) => {
     socket.on('data', common.mustNotCall(() => {

test/parallel/test-net-autoselectfamily.js

@@ -16,12 +16,12 @@ const autoSelectFamilyAttemptTimeout = common.defaultAutoSelectFamilyAttemptTime
 
 // Test that IPV4 is reached if IPV6 is not reachable
 {
-  const ipv4Server = createServer((socket) => {
+  const ipv4Server = createServer(common.mustCall((socket) => {
     socket.on('data', common.mustCall(() => {
       socket.write('response-ipv4');
       socket.end();
     }));
-  });
+  }));
 
   ipv4Server.listen(0, '127.0.0.1', common.mustCall(() => {
     const port = ipv4Server.address().port;
@@ -56,12 +56,12 @@ const autoSelectFamilyAttemptTimeout = common.defaultAutoSelectFamilyAttemptTime
 
 // Test that only the last successful connection is established.
 {
-  const ipv4Server = createServer((socket) => {
+  const ipv4Server = createServer(common.mustCall((socket) => {
     socket.on('data', common.mustCall(() => {
       socket.write('response-ipv4');
       socket.end();
     }));
-  });
+  }));
 
   ipv4Server.listen(0, '127.0.0.1', common.mustCall(() => {
     const port = ipv4Server.address().port;
@@ -116,12 +116,12 @@ if (common.hasIPv6) {
     }));
   });
 
-  const ipv6Server = createServer((socket) => {
+  const ipv6Server = createServer(common.mustCall((socket) => {
     socket.on('data', common.mustCall(() => {
       socket.write('response-ipv6');
       socket.end();
     }));
-  });
+  }));
 
   ipv4Server.listen(0, '127.0.0.1', common.mustCall(() => {
     const port = ipv4Server.address().port;
@@ -184,12 +184,12 @@ if (common.hasIPv6) {
 
 // Test that the option can be disabled
 {
-  const ipv4Server = createServer((socket) => {
+  const ipv4Server = createServer(common.mustCallAtLeast((socket) => {
     socket.on('data', common.mustCall(() => {
       socket.write('response-ipv4');
       socket.end();
     }));
-  });
+  }, 0));
 
   ipv4Server.listen(0, '127.0.0.1', common.mustCall(() => {
     const port = ipv4Server.address().port;

test/parallel/test-net-child-process-connect-reset.js

@@ -35,10 +35,10 @@ if (process.argv[2] === 'child') {
       }
     });
 
-    conn.on('error', (err) => {
+    conn.on('error', common.mustCallAtLeast((err) => {
       // Error emitted on Windows.
       assert.strictEqual(err.code, 'ECONNRESET');
-    });
+    }, 0));
 
     conn.on('connect', common.mustCall(() => {
       cp.kill('SIGKILL');

test/parallel/test-net-connect-abort-controller.js

@@ -18,14 +18,14 @@ server.listen(0, common.mustCall(async () => {
     });
   });
 
-  const assertAbort = async (socket, testName) => {
+  const assertAbort = common.mustCallAtLeast(async (socket, testName) => {
     try {
       await once(socket, 'close');
       assert.fail(`close ${testName} should have thrown`);
     } catch (err) {
       assert.strictEqual(err.name, 'AbortError');
     }
-  };
+  });
 
   async function postAbort() {
     const ac = new AbortController();

test/parallel/test-net-connect-keepalive.js

@@ -8,11 +8,6 @@ const truthyValues = [true, 1, 'true', {}, []];
 const delays = [[123, 0], [456123, 456], [-123000, 0], [undefined, 0]];
 const falseyValues = [false, 0, ''];
 
-const genSetKeepAlive = (desiredEnable, desiredDelay) => (enable, delay) => {
-  assert.strictEqual(enable, desiredEnable);
-  assert.strictEqual(delay, desiredDelay);
-};
-
 for (const value of truthyValues) {
   for (const delay of delays) {
     const server = net.createServer();
@@ -26,7 +21,10 @@ for (const value of truthyValues) {
       );
 
       client._handle.setKeepAlive = common.mustCall(
-        genSetKeepAlive(true, delay[1])
+        (enable, actualDelay) => {
+          assert.strictEqual(enable, true);
+          assert.strictEqual(actualDelay, delay[1]);
+        },
       );
 
       client.on('end', common.mustCall(function() {

test/parallel/test-net-connect-memleak.js

@@ -50,9 +50,9 @@ const gcListener = { ongc() { collected = true; } };
 
 function done(sock) {
   globalThis.gc();
-  setImmediate(() => {
+  setImmediate(common.mustCall(() => {
     assert.strictEqual(collected, true);
     sock.end();
     server.close();
-  });
+  }));
 }