address pr reviews

Author: anonrig

src/encoding_binding.cc

@@ -197,24 +197,23 @@ void BindingData::EncodeInto(const FunctionCallbackInfo<Value>& args) {
 
   char* write_result = static_cast<char*>(buf->Data()) + dest->ByteOffset();
   size_t dest_length = dest->ByteLength();
+  size_t read = 0;
+  size_t written = 0;
 
   // For small strings (length <= 32), use the old V8 path for better
   // performance
-  if (source->Length() <= 32) {
-    size_t nchars;
-    size_t written =
-        source->WriteUtf8V2(isolate,
-                            write_result,
-                            dest_length,
-                            String::WriteFlags::kReplaceInvalidUtf8,
-                            &nchars);
-    binding_data->encode_into_results_buffer_[0] = nchars;
-    binding_data->encode_into_results_buffer_[1] = written;
+  static constexpr int kSmallStringThreshold = 32;
+  if (source->Length() <= kSmallStringThreshold) {
+    written = source->WriteUtf8V2(isolate,
+                                  write_result,
+                                  dest_length,
+                                  String::WriteFlags::kReplaceInvalidUtf8,
+                                  &read);
+    binding_data->encode_into_results_buffer_[0] = static_cast<double>(read);
+    binding_data->encode_into_results_buffer_[1] = static_cast<double>(written);
     return;
   }
 
-  size_t read = 0;
-  size_t written = 0;
   v8::String::ValueView view(isolate, source);
   size_t length_that_fits =
       std::min(static_cast<size_t>(view.length()), dest_length);
@@ -230,8 +229,7 @@ void BindingData::EncodeInto(const FunctionCallbackInfo<Value>& args) {
     length_that_fits -= read;
     dest_length -= read;
     if (length_that_fits != 0 && dest_length != 0) {
-      size_t rest = findBestFit(data, length_that_fits, dest_length);
-      if (rest != 0) {
+      if (size_t rest = findBestFit(data, length_that_fits, dest_length)) {
         DCHECK_LE(simdutf::utf8_length_from_latin1(data, rest), dest_length);
         written += simdutf::convert_latin1_to_utf8(data, rest, write_result);
         read += rest;