From 45f3a4298fae1f6ac91ed3762dbf261c3e016a16 Mon Sep 17 00:00:00 2001 From: Renegade334 Date: Fri, 28 Nov 2025 00:01:00 +0000 Subject: [PATCH 1/2] test: use `assert.match` for non-literal regexp tests --- test/parallel/test-max-old-space-size-percentage.js | 12 ++++++++++-- test/parallel/test-tls-junk-server.js | 2 +- 2 files changed, 11 insertions(+), 3 deletions(-) diff --git a/test/parallel/test-max-old-space-size-percentage.js b/test/parallel/test-max-old-space-size-percentage.js index b84344ddb3988d..4f4c083a1db8fa 100644 --- a/test/parallel/test-max-old-space-size-percentage.js +++ b/test/parallel/test-max-old-space-size-percentage.js @@ -41,7 +41,11 @@ invalidPercentages.forEach((input) => { `--max-old-space-size-percentage=${input[0]}`, ], { stdio: ['pipe', 'pipe', 'pipe'] }); assert.notStrictEqual(result.status, 0, `Expected non-zero exit for invalid input ${input[0]}`); - assert(input[1].test(result.stderr.toString()), `Unexpected error message for invalid input ${input[0]}`); + assert.match( + result.stderr.toString(), + input[1], + `Unexpected error message for invalid input ${input[0]}` + ); }); // Test NODE_OPTIONS with valid percentages @@ -61,7 +65,11 @@ invalidPercentages.forEach((input) => { env: { ...process.env, NODE_OPTIONS: `--max-old-space-size-percentage=${input[0]}` } }); assert.notStrictEqual(result.status, 0, `NODE_OPTIONS: Expected non-zero exit for invalid input ${input[0]}`); - assert(input[1].test(result.stderr.toString()), `NODE_OPTIONS: Unexpected error message for invalid input ${input[0]}`); + assert.match( + result.stderr.toString(), + input[1], + `NODE_OPTIONS: Unexpected error message for invalid input ${input[0]}` + ); }); // Test percentage calculation validation diff --git a/test/parallel/test-tls-junk-server.js b/test/parallel/test-tls-junk-server.js index ff491d11a18c3e..a349c35494588b 100644 --- a/test/parallel/test-tls-junk-server.js +++ b/test/parallel/test-tls-junk-server.js @@ -28,7 +28,7 @@ server.listen(0, common.mustCall(function() { expectedErrorMessage = new RegExp('packet length too long'); }; req.once('error', common.mustCall(function(err) { - assert(expectedErrorMessage.test(err.message)); + assert.match(err.message, expectedErrorMessage); server.close(); })); })); From bc74a37427f13d65ab2abf97186c9e60d8ee1892 Mon Sep 17 00:00:00 2001 From: Renegade334 Date: Sat, 29 Nov 2025 14:04:56 +0000 Subject: [PATCH 2/2] fixup! test: use `assert.match` for non-literal regexp tests --- test/parallel/test-max-old-space-size-percentage.js | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/test/parallel/test-max-old-space-size-percentage.js b/test/parallel/test-max-old-space-size-percentage.js index 4f4c083a1db8fa..c5071d2f959ce3 100644 --- a/test/parallel/test-max-old-space-size-percentage.js +++ b/test/parallel/test-max-old-space-size-percentage.js @@ -41,11 +41,7 @@ invalidPercentages.forEach((input) => { `--max-old-space-size-percentage=${input[0]}`, ], { stdio: ['pipe', 'pipe', 'pipe'] }); assert.notStrictEqual(result.status, 0, `Expected non-zero exit for invalid input ${input[0]}`); - assert.match( - result.stderr.toString(), - input[1], - `Unexpected error message for invalid input ${input[0]}` - ); + assert.match(result.stderr.toString(), input[1]); }); // Test NODE_OPTIONS with valid percentages @@ -65,11 +61,7 @@ invalidPercentages.forEach((input) => { env: { ...process.env, NODE_OPTIONS: `--max-old-space-size-percentage=${input[0]}` } }); assert.notStrictEqual(result.status, 0, `NODE_OPTIONS: Expected non-zero exit for invalid input ${input[0]}`); - assert.match( - result.stderr.toString(), - input[1], - `NODE_OPTIONS: Unexpected error message for invalid input ${input[0]}` - ); + assert.match(result.stderr.toString(), input[1]); }); // Test percentage calculation validation