Skip to content

Commit 252a50a

Browse files
committed
refactor: ordering
1 parent 7ee87dd commit 252a50a

File tree

1 file changed

+10
-5
lines changed

1 file changed

+10
-5
lines changed

src/server/server.ts

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -342,6 +342,15 @@ export class Server<Context extends ServerContext> {
342342

343343
const msgLogger = logger.child().withContext({ messageId: message.id });
344344

345+
// Skip permission check for file-auth-message (they're responses, not requests)
346+
if (
347+
message.type === "file" &&
348+
message.payload.type === "file-auth-message"
349+
) {
350+
// Just ignore this message that's sent by the client
351+
return true;
352+
}
353+
345354
// Extract fileId from FileMessage payload if document is undefined
346355
const fileId =
347356
message.type === "file" &&
@@ -409,16 +418,12 @@ export class Server<Context extends ServerContext> {
409418
}
410419

411420
if (message.type === "file") {
412-
if (message.payload.type === "file-auth-message") {
413-
// Just ignore this message that's sent by the client
414-
return false;
415-
}
416421
await client.send(
417422
new FileMessage(
418423
{
419424
type: "file-auth-message",
420425
permission: "denied",
421-
reason: `Insufficient permissions to access file ${message.payload.fileId}`,
426+
reason: "Insufficient permissions to access file",
422427
},
423428
message.context,
424429
message.encrypted,

0 commit comments

Comments
 (0)