cleanup(core): remove unused mouse event listeners from tui (#33368)

leosvelperez · web-flow · commit c933660b8853 · 2025-11-04T13:21:10.000-05:00
Cleans up unused mouse event listeners from the TUI.
diff --git a/packages/nx/src/native/tui/app.rs b/packages/nx/src/native/tui/app.rs
@@ -1,5 +1,5 @@
 use color_eyre::eyre::Result;
-use crossterm::event::{KeyCode, KeyEvent, KeyModifiers, MouseEvent, MouseEventKind};
+use crossterm::event::{KeyCode, KeyEvent, KeyModifiers};
 use hashbrown::HashSet;
 use napi::bindgen_prelude::External;
 use napi::threadsafe_function::{ErrorStrategy, ThreadsafeFunction};
@@ -807,45 +807,6 @@ impl App {
                     }
                 }
             }
-            tui::Event::Mouse(mouse) => {
-                // If the app is in interactive mode, interactions are with
-                // the running task, not the app itself
-                if !self.is_interactive_mode() {
-                    // Record that the user has interacted with the app
-                    self.user_has_interacted = true;
-                }
-
-                if matches!(self.focus, Focus::MultipleOutput(_)) {
-                    self.handle_mouse_event(mouse).ok();
-                    return Ok(false);
-                }
-
-                match mouse.kind {
-                    MouseEventKind::ScrollUp => {
-                        if matches!(self.focus, Focus::TaskList) {
-                            self.dispatch_action(Action::ScrollUp);
-                        } else {
-                            self.handle_key_event(KeyEvent::new(
-                                KeyCode::Up,
-                                KeyModifiers::empty(),
-                            ))
-                            .ok();
-                        }
-                    }
-                    MouseEventKind::ScrollDown => {
-                        if matches!(self.focus, Focus::TaskList) {
-                            self.dispatch_action(Action::ScrollDown);
-                        } else {
-                            self.handle_key_event(KeyEvent::new(
-                                KeyCode::Down,
-                                KeyModifiers::empty(),
-                            ))
-                            .ok();
-                        }
-                    }
-                    _ => {}
-                }
-            }
             _ => {}
         }
 
@@ -1458,15 +1419,6 @@ impl App {
         let _ = self.handle_pty_resize();
     }
 
-    fn handle_mouse_event(&mut self, mouse_event: MouseEvent) -> io::Result<()> {
-        if let Focus::MultipleOutput(pane_idx) = self.focus {
-            let terminal_pane_data = &mut self.terminal_pane_data[pane_idx];
-            terminal_pane_data.handle_mouse_event(mouse_event)
-        } else {
-            Ok(())
-        }
-    }
-
     /// Forward key events to the currently focused pane, if any.
     fn handle_key_event(&mut self, key: KeyEvent) -> io::Result<()> {
         if let Focus::MultipleOutput(pane_idx) = self.focus {
diff --git a/packages/nx/src/native/tui/components.rs b/packages/nx/src/native/tui/components.rs
@@ -1,5 +1,5 @@
 use color_eyre::eyre::Result;
-use crossterm::event::{KeyEvent, MouseEvent};
+use crossterm::event::KeyEvent;
 use ratatui::layout::{Rect, Size};
 use std::any::Any;
 use tokio::sync::mpsc::UnboundedSender;
@@ -61,7 +61,6 @@ pub trait Component: Any + Send {
     fn handle_events(&mut self, event: Option<Event>) -> Result<Option<Action>> {
         let action = match event {
             Some(Event::Key(key_event)) => self.handle_key_event(key_event)?,
-            Some(Event::Mouse(mouse_event)) => self.handle_mouse_event(mouse_event)?,
             _ => None,
         };
         Ok(action)
@@ -79,19 +78,6 @@ pub trait Component: Any + Send {
         let _ = key; // to appease clippy
         Ok(None)
     }
-    /// Handle mouse events and produce actions if necessary.
-    ///
-    /// # Arguments
-    ///
-    /// * `mouse` - A mouse event to be processed.
-    ///
-    /// # Returns
-    ///
-    /// * `Result<Option<Action>>` - An action to be processed or none.
-    fn handle_mouse_event(&mut self, mouse: MouseEvent) -> Result<Option<Action>> {
-        let _ = mouse; // to appease clippy
-        Ok(None)
-    }
     /// Update the state of the component based on a received action. (REQUIRED)
     ///
     /// # Arguments
diff --git a/packages/nx/src/native/tui/components/terminal_pane.rs b/packages/nx/src/native/tui/components/terminal_pane.rs
@@ -1,5 +1,5 @@
 use arboard::Clipboard;
-use crossterm::event::{KeyCode, KeyEvent, KeyModifiers, MouseEvent, MouseEventKind};
+use crossterm::event::{KeyCode, KeyEvent, KeyModifiers};
 use ratatui::{
     buffer::Buffer,
     layout::{Alignment, Rect},
@@ -156,26 +156,6 @@ impl TerminalPaneData {
         Ok(None)
     }
 
-    pub fn handle_mouse_event(&mut self, event: MouseEvent) -> io::Result<()> {
-        if let Some(pty) = &mut self.pty {
-            let mut pty_mut = pty.as_ref().clone();
-            if self.is_interactive {
-                pty_mut.send_mouse_event(event);
-            } else {
-                match event.kind {
-                    MouseEventKind::ScrollUp => {
-                        self.scroll(ScrollDirection::Up);
-                    }
-                    MouseEventKind::ScrollDown => {
-                        self.scroll(ScrollDirection::Down);
-                    }
-                    _ => {}
-                }
-            }
-        }
-        Ok(())
-    }
-
     pub fn set_interactive(&mut self, interactive: bool) {
         self.is_interactive = interactive;
         // Reset scroll momentum when changing modes
diff --git a/packages/nx/src/native/tui/pty.rs b/packages/nx/src/native/tui/pty.rs
@@ -1,6 +1,6 @@
 use super::scroll_momentum::{ScrollDirection, ScrollMomentum};
 use super::utils::normalize_newlines;
-use crossterm::event::{KeyCode, KeyEvent, MouseEvent, MouseEventKind};
+use crossterm::event::{KeyCode, KeyEvent};
 use parking_lot::Mutex;
 use std::{
     io::{self, Write},
@@ -201,43 +201,6 @@ impl PtyInstance {
         }
     }
 
-    pub fn send_mouse_event(&mut self, event: MouseEvent) {
-        let is_interactive = self.handles_arrow_keys();
-        debug!("Mouse event: {:?}, Interactive: {}", event, is_interactive);
-
-        if is_interactive {
-            // Interactive program - send scroll as arrow keys
-            match event.kind {
-                MouseEventKind::ScrollUp => {
-                    self.write_input(b"\x1b[A").ok();
-                }
-                MouseEventKind::ScrollDown => {
-                    self.write_input(b"\x1b[B").ok();
-                }
-                _ => {}
-            }
-        } else {
-            // Non-interactive program - handle scrolling ourselves
-            match event.kind {
-                MouseEventKind::ScrollUp => {
-                    let amount = self
-                        .scroll_momentum
-                        .lock()
-                        .calculate_momentum(ScrollDirection::Up);
-                    self.scroll_up(amount);
-                }
-                MouseEventKind::ScrollDown => {
-                    let amount = self
-                        .scroll_momentum
-                        .lock()
-                        .calculate_momentum(ScrollDirection::Down);
-                    self.scroll_down(amount);
-                }
-                _ => {}
-            }
-        }
-    }
-
     pub fn get_screen(&self) -> Option<PtyScreenRef> {
         self.parser
             .read()
diff --git a/packages/nx/src/native/tui/tui.rs b/packages/nx/src/native/tui/tui.rs
@@ -2,7 +2,7 @@ use crate::native::tui::theme::THEME;
 use color_eyre::eyre::Result;
 use crossterm::{
     cursor,
-    event::{Event as CrosstermEvent, KeyEvent, KeyEventKind, MouseEvent},
+    event::{Event as CrosstermEvent, KeyEvent, KeyEventKind},
     execute,
     terminal::{EnterAlternateScreen, LeaveAlternateScreen},
 };
@@ -33,7 +33,6 @@ pub enum Event {
     FocusLost,
     Paste(String),
     Key(KeyEvent),
-    Mouse(MouseEvent),
     Resize(u16, u16),
 }
 
@@ -110,9 +109,6 @@ impl Tui {
                             trace!("Key: {:?}", key);
                             _event_tx.send(Event::Key(key)).unwrap();
                           },
-                          CrosstermEvent::Mouse(mouse) => {
-                            _event_tx.send(Event::Mouse(mouse)).unwrap();
-                          },
                           CrosstermEvent::Resize(x, y) => {
                             _event_tx.send(Event::Resize(x, y)).unwrap();
                           },
