hotfix: Fix -Wpessimizing-move in TypeWithId.cpp

yew1eb · yew1eb · commit e23f701eac77 · 2024-04-18T10:17:43.000+08:00
diff --git a/velox/dwio/common/TypeWithId.cpp b/velox/dwio/common/TypeWithId.cpp
@@ -86,7 +86,7 @@ std::unique_ptr<TypeWithId> TypeWithId::duplicate(bool nameAsLowerCase) const {
   std::vector<std::unique_ptr<TypeWithId>> children;
   children.reserve(children_.size());
   for (const auto& child : children_) {
-    children.emplace_back(std::move(child->duplicate(nameAsLowerCase)));
+    children.emplace_back(child->duplicate(nameAsLowerCase));
   }
   return std::make_unique<TypeWithId>(
       nameAsLowerCase ? adjustNameAsLowerCase(type_) : type_,

Original file line number	Diff line number	Diff line change
`@@ -86,7 +86,7 @@ std::unique_ptr<TypeWithId> TypeWithId::duplicate(bool nameAsLowerCase) const {`
`86`	`86`	`std::vector<std::unique_ptr<TypeWithId>> children;`
`87`	`87`	`children.reserve(children_.size());`
`88`	`88`	`for (const auto& child : children_) {`
`89`		`- children.emplace_back(std::move(child->duplicate(nameAsLowerCase)));`
	`89`	`+ children.emplace_back(child->duplicate(nameAsLowerCase));`
`90`	`90`	`}`
`91`	`91`	`return std::make_unique<TypeWithId>(`
`92`	`92`	`nameAsLowerCase ? adjustNameAsLowerCase(type_) : type_,`