Code review

Author: poechsel

asmcomp/cmm.mli

@@ -182,6 +182,9 @@ and operation =
         ty_args : exttype list;
         alloc : bool;
         returns : bool; }
+  (** The [machtype] is the machine type of the result.
+      The [exttype list] describes the unboxing types of the arguments.
+      An empty list means "all arguments are machine words [XInt]". *)
   | Cload of memory_chunk * Asttypes.mutable_flag
   | Calloc
   | Cstore of memory_chunk * Lambda.initialization_or_assignment

middle_end/closure/closure.ml

@@ -798,17 +798,16 @@ let direct_apply env fundesc ufunct uargs ~loc ~attribute =
   then app
   else Usequence(ufunct, app)
 
-(* Add [Value_integer] or [Value_constptr] info to the approximation
-   of an application *)
+(* Add [Value_integer] info to the approximation of an application *)
 
 let strengthen_approx appl approx =
   match approx_ulam appl with
     (Value_const _) as intapprox ->
       intapprox
   | _ -> approx
 
-(* If a term has approximation Value_integer or Value_constptr and is pure,
-   replace it by an integer constant *)
+(* If a term has approximation Value_integer and is pure, replace it by an
+   integer constant *)
 
 let check_constant_result ulam approx =
   match approx with
@@ -1070,12 +1069,14 @@ let rec close ({ backend; fenv; cenv ; mutable_vars } as env) lam =
       close env arg
   | Lprim(Pdirapply,[funct;arg], loc)
   | Lprim(Prevapply,[arg;funct], loc) ->
-      close env       (Lapply{ap_loc=loc;
-                              ap_func=funct;
-                              ap_args=[arg];
-                              ap_tailcall=Default_tailcall;
-                              ap_inlined=Default_inline;
-                              ap_specialised=Default_specialise})
+      close env
+        (Lapply{ap_loc=loc;
+           ap_func=funct;
+           ap_args=[arg];
+           ap_tailcall=Default_tailcall;
+           ap_inlined=Default_inline;
+           ap_specialised=Default_specialise
+        })
   | Lprim(Pgetglobal id, [], loc) ->
       let dbg = Debuginfo.from_location loc in
       check_constant_result (getglobal dbg id)

middle_end/flambda/to_cmm/un_cps_helper.ml

@@ -17,8 +17,8 @@
 open Cmm_helpers
 module P = Flambda_primitive
 
-let unsupported_32_bits () = 
-  Misc.fatal_errorf "32 bits is currently unsupported in Flambda." 
+let unsupported_32_bits () =
+  Misc.fatal_errorf "32 bits is currently unsupported in Flambda."
 
 (* Are we compiling on/for a 32-bit architecture ? *)
 let arch32 = Arch.size_int = 4
@@ -39,7 +39,7 @@ let exttype_of_kind k =
     | Thirty_two -> Cmm.XInt32
     | Sixty_four -> Cmm.XInt64
     end
-  | Fabricated -> Misc.fatal_error "[Fabricated] king not expected here"
+  | Fabricated -> Misc.fatal_error "[Fabricated] kind not expected here"
 
 (* Void *)
 

middle_end/flambda/to_cmm/un_cps_helper.mli

@@ -27,7 +27,7 @@ val arch64 : bool
 val typ_int64 : Cmm.machtype
 (** An adequate Cmm machtype for an int64 (including on a 32-bit target). *)
 
-val  exttype_of_kind : Flambda_kind.t -> Cmm.exttype
+val exttype_of_kind : Flambda_kind.t -> Cmm.exttype
 
 (** {2 Data items} *)
 

runtime/compact.c

@@ -15,7 +15,6 @@
 
 #define CAML_INTERNALS
 
-
 #include <string.h>
 
 #include "caml/address_class.h"