performance/multi-node: Fix possible race. #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed per_iteration_data struct. - This struct was being used to pass in a thread id to each pthread but that thread_id may have been overwritten before creating the next thread. - The thread id and message size was moved to the per_thread_data struct which is then passed to pthread create in an effort to avoid the race described above. Signed-off-by: Evan Harvey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I find this way of passing data to the thread function much more readable than what was there before.
This struct was being used to pass in a thread id
to each pthread but that thread_id may have been
overwritten before creating the next thread.
The thread id and message size was moved to the
per_thread_data struct which is then passed to
pthread create in an effort to avoid the race described above.
I'm not sure if theee is a race here before this PR but it looked like the thread id field of the other key could get stomped on between calls to pthread create.
Signed-off-by: Evan Harvey [email protected]