-
Notifications
You must be signed in to change notification settings - Fork 0
373 - backup options screen #948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
373 - backup options screen #948
Conversation
PR SummaryAdded a new Changes
autogenerated by presubmit.ai |
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚨 Pull request needs attention.
Review Summary
Commits Considered (1)
- bad0c68: feat: add BackupOptionsScreen for additional backup setup
Add BackupOptionsScreen with the following features:
- Three backup options: device backup, cloud backup, and recovery phrase
- Theme-aware icon colors for light/dark mode
- Custom back handler to show skip warning dialog
- Hardware back button interception for warning dialog
- Native screen launches for each backup type using NativeScreenName enum
- Recommended badges for device and cloud backup options
- Skip warning with error-styled confirmation button
- Uses theme tokens for consistent styling
🤖 Generated with Claude Code
Co-Authored-By: Claude [email protected]
Closes #373
Files Processed (2)
- packages/screens/src/onboarding/BackupOptionsScreen.query.tsx (1 hunk)
- packages/screens/src/onboarding/index.ts (1 hunk)
Actionable Comments (1)
-
packages/screens/src/onboarding/BackupOptionsScreen.query.tsx [124-126]
possible bug: "Icon names appear to be swapped between backup options."
Skipped Comments (3)
-
packages/screens/src/onboarding/BackupOptionsScreen.query.tsx [32-32]
maintainability: "Avoid using global state for inter-component communication."
-
packages/screens/src/onboarding/BackupOptionsScreen.query.tsx [57-67]
possible issue: "Potential race condition with setTimeout for dialog dismissal."
-
packages/screens/src/onboarding/BackupOptionsScreen.query.tsx [79-83]
maintainability: "Duplicated bridge availability check across handlers."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ LGTM!
Review Summary
Commits Considered (1)
- 30f5302: fix: use theme system for icon colors instead of hardcoded values
Replace hardcoded color scheme check and hex colors with theme.color.val
for proper theme-aware icon colors. Removes useColorScheme dependency.
🤖 Generated with Claude Code
Co-Authored-By: Claude [email protected]
Closes #373
Files Processed (1)
- packages/screens/src/onboarding/BackupOptionsScreen.query.tsx (1 hunk)
Actionable Comments (0)
Skipped Comments (2)
-
packages/screens/src/onboarding/BackupOptionsScreen.query.tsx [39-39]
maintainability: "Avoid using global state for component communication."
-
packages/screens/src/onboarding/BackupOptionsScreen.query.tsx [64-74]
possible issue: "Avoid relying on arbitrary timeout for sequencing operations."
| * Shows warning dialog when user tries to exit without setting up additional backup | ||
| * Both header back button and hardware back button trigger the warning | ||
| */ | ||
| export function BackupOptionsScreen(): React.ReactElement { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this screen is not needed, we will reuse native backup screen for hardware (secure enclave) type profile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @lmcmz , I have created a new PR for this screen here as the notification preferences branch has been deleted: #963
This branch implements this screen from Figma: https://www.figma.com/design/ELsn1EA0ptswW1f21PZqWp/%F0%9F%9F%A2-Flow-Wallet?node-id=11495-3499&m=dev
Currently it shows the 3 back up options for secure profiles; when the user selects any of the 3 options, it redirects to the native flow for each option. Zena has already tested this flow, but if you want to remove this screen then I can update the navigation to go straight to the native backup options screen. Either way, I think we will need this screen for the next milestone when backup options are implemented for full profiles.
Let me know what you think.
35f0ba5 to
b4feef7
Compare
30f5302 to
b4feef7
Compare
🔗 Related Issues
Closes #373
Linked automatically from the branch name. If incorrect, edit:
📝 Description
📸 Screenshots/Videos