Skip to content

Commit a199bb7

Browse files
committed
fix: increase Typesense max-per-page server option
The forum sets a constant search comment count of 1000 ( https://github.com/openedx/forum/blob/51ec507/forum/constants.py ), and the Elasticsearch and Meilisearch backends respect that. So to use this value for Typesense too, we need to increase the max-per-page server option. The default is 250 in Typesense. Private-ref: https://tasks.opencraft.com/browse/BB-9975
1 parent c12d3d4 commit a199bb7

File tree

2 files changed

+5
-0
lines changed

2 files changed

+5
-0
lines changed

tutor_typesense/patches/k8s-deployments

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,9 @@ spec:
2424
value: "{{ TYPESENSE_BOOTSTRAP_API_KEY }}"
2525
- name: TYPESENSE_DATA_DIR
2626
value: /typesense_data
27+
# forum expects up to 1000 per page - https://github.com/openedx/forum/blob/master/forum/constants.py
28+
- name: TYPESENSE_MAX_PER_PAGE
29+
value: "1000"
2730
ports:
2831
- containerPort: 8108
2932
volumeMounts:

tutor_typesense/patches/local-docker-compose-services

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,4 +6,6 @@ typesense:
66
environment:
77
TYPESENSE_API_KEY: "{{ TYPESENSE_BOOTSTRAP_API_KEY }}"
88
TYPESENSE_DATA_DIR: "/typesense_data"
9+
# forum expects up to 1000 per page - https://github.com/openedx/forum/blob/master/forum/constants.py
10+
TYPESENSE_MAX_PER_PAGE: "1000"
911
restart: unless-stopped

0 commit comments

Comments
 (0)