Skip to content

Commit cbc9045

Browse files
committed
update tests
Signed-off-by: alex boten <[email protected]>
1 parent 064b884 commit cbc9045

File tree

3 files changed

+41
-32
lines changed

3 files changed

+41
-32
lines changed

otelconf/config_test.go

Lines changed: 20 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -222,7 +222,7 @@ func TestNewSDK(t *testing.T) {
222222

223223
var v10OpenTelemetryConfig = OpenTelemetryConfiguration{
224224
Disabled: ptr(false),
225-
FileFormat: "1.0-rc.1",
225+
FileFormat: "1.0-rc.2",
226226
AttributeLimits: &AttributeLimits{
227227
AttributeCountLimit: ptr(128),
228228
AttributeValueLengthLimit: ptr(4096),
@@ -426,8 +426,9 @@ var v10OpenTelemetryConfig = OpenTelemetryConfiguration{
426426
},
427427
Exporter: PullMetricExporter{
428428
PrometheusDevelopment: &ExperimentalPrometheusMetricExporter{
429-
Host: ptr("localhost"),
430-
Port: ptr(9464),
429+
Host: ptr("localhost"),
430+
Port: ptr(9464),
431+
TranslationStrategy: ptr(ExperimentalPrometheusMetricExporterTranslationStrategyUnderscoreEscapingWithSuffixes),
431432
WithResourceConstantLabels: &IncludeExclude{
432433
Excluded: []string{"service.attr1"},
433434
Included: []string{"service*"},
@@ -610,8 +611,10 @@ var v10OpenTelemetryConfig = OpenTelemetryConfiguration{
610611
},
611612
Tracers: []ExperimentalTracerMatcherAndConfig{
612613
{
613-
Config: ptr(ExperimentalTracerConfig{}),
614-
Name: ptr("io.opentelemetry.contrib.*"),
614+
Config: ptr(ExperimentalTracerConfig{
615+
Disabled: ptr(false),
616+
}),
617+
Name: ptr("io.opentelemetry.contrib.*"),
615618
},
616619
},
617620
},
@@ -809,14 +812,18 @@ func TestParseYAML(t *testing.T) {
809812
line 1: cannot unmarshal !!str ` + "`notabool`" + ` into bool`),
810813
},
811814
{
812-
name: "invalid nil name",
813-
input: "v1.0.0_invalid_nil_name.yaml",
814-
wantErr: errors.New(`cannot unmarshal field name in NameStringValuePair required`),
815+
name: "invalid nil name",
816+
input: "v1.0.0_invalid_nil_name.yaml",
817+
wantErr: errors.New(`unmarshal error in *otelconf.BatchSpanProcessor
818+
unmarshal error in *otelconf.SpanExporter
819+
cannot unmarshal field name in NameStringValuePair required`),
815820
},
816821
{
817-
name: "invalid nil value",
818-
input: "v1.0.0_invalid_nil_value.yaml",
819-
wantErr: errors.New(`cannot unmarshal field value in NameStringValuePair required`),
822+
name: "invalid nil value",
823+
input: "v1.0.0_invalid_nil_value.yaml",
824+
wantErr: errors.New(`unmarshal error in *otelconf.BatchLogRecordProcessor
825+
unmarshal error in *otelconf.LogRecordExporter
826+
cannot unmarshal field value in NameStringValuePair required`),
820827
},
821828
{
822829
name: "valid v0.2 config",
@@ -845,7 +852,7 @@ func TestParseYAML(t *testing.T) {
845852

846853
for _, tt := range tests {
847854
t.Run(tt.name, func(t *testing.T) {
848-
b, err := os.ReadFile(filepath.Join("..", "testdata", tt.input))
855+
b, err := os.ReadFile(filepath.Join("testdata", tt.input))
849856
require.NoError(t, err)
850857

851858
got, err := ParseYAML(b)
@@ -990,7 +997,7 @@ func TestParseYAMLWithEnvironmentVariables(t *testing.T) {
990997
t.Setenv("VALUE_WITH_ESCAPE", "value$$") // A valid replacement text, used verbatim, not replaced with "Never use this value"
991998
for _, tt := range tests {
992999
t.Run(tt.name, func(t *testing.T) {
993-
b, err := os.ReadFile(filepath.Join("..", "testdata", tt.input))
1000+
b, err := os.ReadFile(filepath.Join("testdata", tt.input))
9941001
require.NoError(t, err)
9951002

9961003
got, err := ParseYAML(b)

otelconf/metric_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1338,7 +1338,7 @@ func TestPrometheusReaderOpts(t *testing.T) {
13381338
// WithoutUnits: ptr(true),
13391339
WithResourceConstantLabels: &IncludeExclude{},
13401340
},
1341-
wantOptions: 4,
1341+
wantOptions: 2,
13421342
},
13431343
{
13441344
name: "all set false",

otelconf/testdata/ca.crt

Lines changed: 20 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,22 @@
11
-----BEGIN CERTIFICATE-----
2-
MIIDNjCCAh4CCQC0I5IQT7eziDANBgkqhkiG9w0BAQsFADBdMQswCQYDVQQGEwJB
3-
VTESMBAGA1UECAwJQXVzdHJhbGlhMQ8wDQYDVQQHDAZTeWRuZXkxEjAQBgNVBAoM
4-
CU15T3JnTmFtZTEVMBMGA1UEAwwMTXlDb21tb25OYW1lMB4XDTIyMDgwMzA0MTky
5-
MVoXDTMyMDczMTA0MTkyMVowXTELMAkGA1UEBhMCQVUxEjAQBgNVBAgMCUF1c3Ry
6-
YWxpYTEPMA0GA1UEBwwGU3lkbmV5MRIwEAYDVQQKDAlNeU9yZ05hbWUxFTATBgNV
7-
BAMMDE15Q29tbW9uTmFtZTCCASIwDQYJKoZIhvcNAQEBBQADggEPADCCAQoCggEB
8-
AMhGP0dy3zvkdx9zI+/XVjPOWlER0OUp7Sgzidc3nLOk42+bH4ofIVNtOFVqlNKi
9-
O1bImu238VdBhd6R5IZZ1ZdIMcCeDgSJYu2X9wA3m4PKz8IdXo5ly2OHghhmCvqG
10-
WxgqDj5wPXiczQwuf1EcDMtRWbXJ6Z/XH1U68R/kRdNLkiZ2LwtjoQpis5XYckLL
11-
CrdF+AL6GeDIe0Mh9QGs26Vux+2kvaOGNUWRPE6Wt4GkqyKqmzYfR9HbflJ4xHT2
12-
I+jE1lg+jMBeom7z8Z90RE4GGcHjO+Vens/88r5EAjTnFj1Kb5gL2deSHY1m/++R
13-
Z/kRyg+zQJyw4fAzlAA4+VkCAwEAATANBgkqhkiG9w0BAQsFAAOCAQEAM3gRdTKX
14-
eGwGYVmmKqA2vTxeigQYLHml7OSopcWj2wJfxfp49HXPRuvgpQn9iubxO3Zmhd83
15-
2X1E+T0A8oy5CfxgpAhHb3lY0jm3TjKXm6m+dSODwL3uND8tX+SqR8sRTFxPvPuo
16-
pmvhdTZoRI3EzIiHLTgCuSU25JNP/vrVoKk0JvCkDYTU/WcVfj0v95DTMoWR4JGz
17-
mtBwrgD0EM2XRw5ZMc7sMPli1gqmCbCQUrDZ+rPB78WDCBILBd8Cz75qYTUp98BY
18-
akJyBckdJHAdyEQYDKa9HpmpexOO7IhSXCTEN1DEBgpZgEi/lBDRG/b0OzenUUgt
19-
LUABtWt3pNQ9HA==
2+
MIIDnzCCAoegAwIBAgIUBxmeJyLb45dq6RmW5bOFIl8VON0wDQYJKoZIhvcNAQEL
3+
BQAwXzELMAkGA1UEBhMCVVMxEzARBgNVBAgMCkNhbGlmb3JuaWExFjAUBgNVBAcM
4+
DVNhbiBGcmFuY2lzY28xEzARBgNVBAoMCk15IENvbXBhbnkxDjAMBgNVBAMMBU15
5+
IENBMB4XDTI1MDQxNTEyMjM0MloXDTI2MDQxNTEyMjM0MlowXzELMAkGA1UEBhMC
6+
VVMxEzARBgNVBAgMCkNhbGlmb3JuaWExFjAUBgNVBAcMDVNhbiBGcmFuY2lzY28x
7+
EzARBgNVBAoMCk15IENvbXBhbnkxDjAMBgNVBAMMBU15IENBMIIBIjANBgkqhkiG
8+
9w0BAQEFAAOCAQ8AMIIBCgKCAQEA3ywD9NQpjd2H/PaHnodeX6YWn67OaqODTsUs
9+
mOcJphhfya+/lybNtWScHoiURpB40QhTacDsjQ7J0Trykznm6ynl06uSQZKONVxo
10+
LW+FmCBDRE+BqmFBFdMEMvRBGVxns7IctzY//GaZbX81Ni1pyLrzrRG9B5LuU7Sb
11+
yggByJrut72RC7bRgAz8v2s++JKvDVKRk3hTmSwCiEC30s9QUu1N9BGnib5V09v/
12+
Sa7wseVp7ICGC0YckCkJMIjvzpaVMFA9/uMHFnloty+gMs/eMWGw0bb391QJb+k8
13+
WQHRZAlKTaLKVqeXC5G5CvK+u3q6j+4hQG46IclOJ76lRY//MwIDAQABo1MwUTAd
14+
BgNVHQ4EFgQU5QWO+akQtDDflpGrTaXR4zEeah8wHwYDVR0jBBgwFoAU5QWO+akQ
15+
tDDflpGrTaXR4zEeah8wDwYDVR0TAQH/BAUwAwEB/zANBgkqhkiG9w0BAQsFAAOC
16+
AQEAkNcppwcF+zjeZNmzGTccO1lSkPeC2LLlp/oEna0KUEGuKDFCemamxvESmua0
17+
+bXt9vw1qd+VztDIZ+zB+yAYYWyKYm41Nu1+IweLD8jmKPoQc5UXiWlSdF1Sjeub
18+
9vcuX/G+FPOAGklt6X62y/jnlcumv1SOMB2BftSdD1Co8Yl9NRqFf3/OiEvd10bH
19+
UXttTae4XEOp5p06ZFHW4JAnrHWBeuiLNJoswdKbA3rQO1Z6u5ioakluNHiCJX6T
20+
fcJxbEVmorLNfBOnZTm61rPsC5aVtvFAxXDDb6B00KBW9FrV9m2MEFw71bMmC8X3
21+
rFaC9Gm5g2bfyX/65YBQyLwXRA==
2022
-----END CERTIFICATE-----

0 commit comments

Comments
 (0)