-
Notifications
You must be signed in to change notification settings - Fork 706
feat: add sampling attributes for jaeger remote sampler #8073
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add sampling attributes for jaeger remote sampler #8073
Conversation
|
|
|
cc code owner: @yurishkuro PTAL |
dmathieu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those attributes don't match anything defined in semantic conventions.
yurishkuro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest writing a test in a different package like jaegerremote_test, to make sure you got the visibility of new functions / types correctly
|
Thank you for this PR! Originally when I looked at this problem there was no way in the API to pass back attributes (I think I even had an option issue about that). |
Can we do anything about it? Those attributes provide back-compatibility with jaeger-remote-sampler and can be turned only by an option. So yeah it is kinda jaeger attributes. |
|
@dmathieu @yurishkuro If you’re okay with it, I could try a different approach - add two new options - functions that create attributes for probabilistic/ratelimiting samplers, so user can define their own attributes to solve this issue. |
|
Sorry, my assessment was wrong. As these are jaeger specific, they shouldn't need semantic conventions. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8073 +/- ##
=====================================
Coverage 81.8% 81.8%
=====================================
Files 194 194
Lines 13362 13380 +18
=====================================
+ Hits 10936 10954 +18
Misses 2029 2029
Partials 397 397
🚀 New features to boost your workflow:
|
|
@yurishkuro I added new test in different package and answered on all comments. Review pls |
We can fix the CI errors before entering the review to reduce some trivial checks. 😁 |
9cc7fce to
8e6fd09
Compare
|
@etilite please add a CHANGELOG |
|
@etilite There are currently some conflicts; please fix them. |
|
@flc1125 resolved conflicts but now ci/cd failing. Probably need just to retry these jobs, can't do it myself. |
|
👏 @etilite do you want to make the corresponding changes in Jaeger to recognize the prefixed attributes? |
|
👏 @yurishkuro I'm not familiar with Jaeger backend library so it will be nice if you can handle it |
Which problem is this PR solving?
Resolves #3653
Resolves #691
Description of the changes
WithAttributesOnwhich addsjaeger.sampler.paramandjaeger.sampler.typeattributes for sampled spans