Skip to content

Commit b18f9e7

Browse files
committed
added TODO comments about bool arrays
1 parent ce506ea commit b18f9e7

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

rust/otap-dataflow/crates/pdata/src/otlp/attributes.rs

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -120,6 +120,8 @@ pub(crate) fn encode_any_value(
120120
result_buf.encode_string(ANY_VALUE_STRING_VALUE, val);
121121
}
122122
AttributeValueType::Bool => {
123+
// TODO handle case when bool column is missing we correct the default value handling
124+
// https://github.com/open-telemetry/otel-arrow/issues/1449
123125
if let Some(attr_bool) = &attr_arrays.attr_bool {
124126
if let Some(val) = attr_bool.value_at(index) {
125127
result_buf.encode_field_tag(ANY_VALUE_BOOL_VALUE, wire_types::VARINT);
@@ -191,6 +193,9 @@ mod test {
191193
rb_builder.append_double(0.0);
192194
rb_builder.append_int(0);
193195

196+
// TODO include test cases for bool once we've corrected the default value handling:
197+
// https://github.com/open-telemetry/otel-arrow/issues/1449
198+
194199
let mut fields = vec![];
195200
let mut columns = vec![];
196201
rb_builder.finish(&mut columns, &mut fields).unwrap();

0 commit comments

Comments
 (0)