Merge branch 'worlfown-markdownlinter' of https://github.com/lsiepel/openhab-addons into worlfown-markdownlinter

Author: lsiepel

.github/dependabot.yml

@@ -0,0 +1,45 @@
+# To get started with Dependabot version updates, you'll need to specify which
+# package ecosystems to update and where the package manifests are located.
+# Please see the documentation for all configuration options:
+# https://docs.github.com/en/code-security/dependabot/working-with-dependabot/dependabot-options-reference
+
+version: 2
+
+# this would enable querying all packages from our repo first,
+# disabled for now as we do not want to use it. Kept for reference.
+#registries:
+#  openhab-jfrog:
+#    type: "maven-repository"
+#    url: "https://openhab.jfrog.io/artifactory/libs-all/"
+
+updates:
+  - package-ecosystem: "github-actions" # See documentation for possible values
+    directory: "/" # Location of package manifests
+    schedule:
+      interval: "weekly"
+    open-pull-requests-limit: 10
+    labels:
+      - dependencies
+
+  - package-ecosystem: "maven" # See documentation for possible values
+    directory: "/" # Location of package manifests
+    schedule:
+      interval: "weekly"
+    open-pull-requests-limit: 15
+    labels:
+      - dependencies
+    groups:
+      jacoco:
+        patterns:
+          - "*jacoco*"
+    allow:
+      - dependency-name: "org.apache.maven.plugins:*"
+      - dependency-name: "org.codehaus.mojo:*"
+      - dependency-name: "*jacoco*" # code coverage tool, both tool and plugin
+      - dependency-name: "*plugin*"
+    ignore:
+      - dependency-name: "com.github.jaxb-xew-plugin:jaxb-xew-plugin" # updated with core
+      - dependency-name: "com.diffplug.spotless:spotless-maven-plugin" # updated together with SAT
+      - dependency-name: "*graalvm*" # do not touch graalvm related stuff
+      - dependency-name: "org.openapitools:openapi*" # updated togeter with openapi generator
+      - dependency-name: "org.apache.openjpa:openjpa*" # should be done with openjpa upgrades"

CODEOWNERS

@@ -133,7 +133,6 @@
 /bundles/org.openhab.binding.folding/ @fa2k
 /bundles/org.openhab.binding.foobot/ @airboxlab @Hilbrand
 /bundles/org.openhab.binding.freeathome/ @andrasU
-/bundles/org.openhab.binding.freebox/ @lolodomo
 /bundles/org.openhab.binding.freeboxos/ @clinique
 /bundles/org.openhab.binding.freecurrency/ @J-N-K
 /bundles/org.openhab.binding.frenchgovtenergydata/ @clinique
@@ -170,7 +169,7 @@
 /bundles/org.openhab.binding.homewizard/ @Daniel-42
 /bundles/org.openhab.binding.hpprinter/ @cossey
 /bundles/org.openhab.binding.http/ @J-N-K
-/bundles/org.openhab.binding.hue/ @cweitkamp @andrewfg
+/bundles/org.openhab.binding.hue/ @andrewfg
 /bundles/org.openhab.binding.huesync/ @pgfeller
 /bundles/org.openhab.binding.hydrawise/ @digitaldan
 /bundles/org.openhab.binding.hyperion/ @tavalin
@@ -497,7 +496,7 @@
 /itests/org.openhab.binding.astro.tests/ @gerrieg
 /itests/org.openhab.binding.avmfritz.tests/ @cweitkamp
 /itests/org.openhab.binding.feed.tests/ @openhab/add-ons-maintainers
-/itests/org.openhab.binding.hue.tests/ @cweitkamp
+/itests/org.openhab.binding.hue.tests/ @openhab/add-ons-maintainers
 /itests/org.openhab.binding.max.tests/ @marcelrv
 /itests/org.openhab.binding.mielecloud.tests/ @BjoernLange
 /itests/org.openhab.binding.modbus.tests/ @ssalonen

CONTRIBUTING.md

@@ -24,7 +24,7 @@ received feedback on what to improve.
 We're trying very hard to keep openHAB lean and focused. We don't want it
 to do everything for everybody. This means that we might decide against
 incorporating a new feature. However, there might be a way to implement
-that feature *on top of* openHAB.
+that feature _on top of_ openHAB.
 
 ### Discuss your design in the discussion forum
 
@@ -60,7 +60,7 @@ your documentation changes for clarity, concision, and correctness, as
 well as a clean documentation build.
 
 Write clean code. Universally formatted code promotes ease of writing, reading,
-and maintenance. 
+and maintenance.
 
 Pull requests descriptions should be as clear as possible and include a
 reference to all the issues that they address.
@@ -88,7 +88,7 @@ pass it on as an open-source patch.  The rules are pretty simple: if you
 can certify the below (from
 [developercertificate.org](https://developercertificate.org/)):
 
-```
+```text
 Developer Certificate of Origin
 Version 1.1
 
@@ -129,20 +129,22 @@ By making a contribution to this project, I certify that:
 
 then you just add a line to every git commit message:
 
-    Signed-off-by: Joe Smith <[email protected]>
+```text
+Signed-off-by: Joe Smith <[email protected]>
+```
 
 using your real name (sorry, no pseudonyms or anonymous contributions.) and an
 e-mail address under which you can be reached (sorry, no github noreply e-mail
-addresses (such as [email protected]) or other non-reachable
+addresses (such as `[email protected]`) or other non-reachable
 addresses are allowed).
 
 On the command line you can use `git commit -s` to sign off the commit.
 
 ### How can I become a maintainer?
 
-* Step 1: learn the component inside out
-* Step 2: make yourself useful by contributing code, bugfixes, support etc.
-* Step 3: volunteer on [the discussion group](https://github.com/openhab/openhab-addons/issues?labels=question&page=1&state=open)
+- Step 1: learn the component inside out
+- Step 2: make yourself useful by contributing code, bugfixes, support etc.
+- Step 3: volunteer on [the discussion group](https://github.com/openhab/openhab-addons/issues?labels=question&page=1&state=open)
 
 Don't forget: being a maintainer is a time investment. Make sure you will have time to make yourself available.
 You don't have to be a maintainer to make a difference on the project!
@@ -153,22 +155,21 @@ We want to keep the openHAB community awesome, growing and collaborative. We
 need your help to keep it that way. To help with this we have come up with some
 general guidelines for the community as a whole:
 
-* Be nice: Be courteous, respectful and polite to fellow community members: no
+- Be nice: Be courteous, respectful and polite to fellow community members: no
   regional, racial, gender, or other abuse will be tolerated. We like nice people
   way better than mean ones!
 
-* Encourage diversity and participation: Make everyone in our community
+- Encourage diversity and participation: Make everyone in our community
   feel welcome, regardless of their background and the extent of their
   contributions, and do everything possible to encourage participation in
   our community.
 
-* Keep it legal: Basically, don't get us in trouble. Share only content that
+- Keep it legal: Basically, don't get us in trouble. Share only content that
   you own, do not share private or sensitive information, and don't break the
   law.
 
-* Stay on topic: Make sure that you are posting to the correct channel
+- Stay on topic: Make sure that you are posting to the correct channel
   and avoid off-topic discussions. Remember when you update an issue or
   respond to an email you are potentially sending to a large number of
   people.  Please consider this before you update.  Also remember that
   nobody likes spam.
-

README.md

@@ -1,6 +1,6 @@
 # openHAB Add-ons
 
-<img align="right" width="220" src="./logo.png" />
+<img align="right" width="220" src="logo.png" alt="openHAB logo" />
 
 [![GitHub Actions Build Status](https://github.com/openhab/openhab-addons/actions/workflows/ci-build.yml/badge.svg?branch=main)](https://github.com/openhab/openhab-addons/actions/workflows/ci-build.yml)
 [![Jenkins Build Status](https://ci.openhab.org/job/openHAB-Addons/badge/icon)](https://ci.openhab.org/job/openHAB-Addons/)
@@ -11,18 +11,18 @@ This repository contains the official set of add-ons that are implemented on top
 Add-ons that got accepted in here will be maintained (e.g. adapted to new core APIs)
 by the [openHAB Add-on maintainers](https://github.com/orgs/openhab/teams/add-ons-maintainers).
 
-To get started with binding development, follow our guidelines and tutorials over at https://www.openhab.org/docs/developer.
+To get started with add-on development, follow our guidelines and tutorials over at <https://www.openhab.org/docs/developer>.
 
-If you are interested in openHAB Core development, we invite you to come by on https://github.com/openhab/openhab-core.
+If you are interested in openHAB Core development, we invite you to come by on <https://github.com/openhab/openhab-core>.
 
 ## Add-ons in other repositories
 
 Some add-ons are not in this repository, but still part of the official [openHAB distribution](https://github.com/openhab/openhab-distro).
 An incomplete list of other repositories follows below:
 
-* https://github.com/openhab/org.openhab.binding.zwave
-* https://github.com/openhab/org.openhab.binding.zigbee
-* https://github.com/openhab/openhab-webui
+- <https://github.com/openhab/org.openhab.binding.zwave>
+- <https://github.com/openhab/org.openhab.binding.zigbee>
+- <https://github.com/openhab/openhab-webui>
 
 ## Development / Repository Organization
 
@@ -33,7 +33,7 @@ The official IDE (Integrated development environment) is Eclipse.
 
 You find the following repository structure:
 
-```
+```text
 .
 +-- bom       Maven buildsystem: Bill of materials
 |   +-- openhab-addons  Lists all extensions for other repos to reference them
@@ -76,7 +76,7 @@ mvn clean install -pl :org.openhab.binding.astro
 
 If you have a binding that has dependencies that are dynamically as specified in the feature.xml you can create a `.kar` instead of a `.jar` file.
 A `.kar` file will include the feature.xml and when added to openHAB will load and activate any dependencies specified in the feature.xml file.
-To create a `.kar` file run maven with the goal `karaf:kar`:
+To create a `.kar` file run Maven with the goal `karaf:kar`:
 
 ```shell
 mvn clean install karaf:kar -pl :org.openhab.binding.astro
@@ -112,7 +112,7 @@ When translations are added or updated and approved in Crowdin, a pull request i
 Therefore translations should not be edited in the openHAB-addons repo, but only in Crowdin.
 Otherwise translation are overridden by the automatic process.
 
-To fill the English properties file run the following maven command on an add-on:
+To fill the English properties file run the following Maven command on an add-on:
 
 ```shell
 mvn i18n:generate-default-translations
@@ -124,10 +124,9 @@ In some cases the command does not work, and requires the full plug-in name.
 In that case use:
 
 ```shell
-mvn org.openhab.core.tools:i18n-maven-plugin:3.4.0:generate-default-translations
+mvn org.openhab.core.tools:i18n-maven-plugin:5.0.0:generate-default-translations
 ```
 
-
 #### Code Quality
 
 To check if your code is following the [code style](https://www.openhab.org/docs/developer/guidelines.html#b-code-formatting-rules-style) run:
@@ -136,7 +135,7 @@ To check if your code is following the [code style](https://www.openhab.org/docs
 mvn spotless:check
 ```
 
-To reformat your code so it conforms to the code style you can run: 
+To reformat your code so it conforms to the code style you can run:
 
 ```shell
 mvn spotless:apply
@@ -145,7 +144,7 @@ mvn spotless:apply
 ### Integration Tests
 
 When your add-on also has an integration test in the `itests` directory, you may need to update the runbundles in the `itest.bndrun` file when the Maven dependencies change.
-Maven can resolve the integration test dependencies automatically by executing: 
+Maven can resolve the integration test dependencies automatically by executing:
 
 ```shell
 mvn clean install -DwithResolver -DskipChecks
@@ -157,6 +156,6 @@ The build generates a `.jar` file per bundle in the respective bundle `/target`
 
 We have assembled some step-by-step guides for different IDEs on our developer documentation website:
 
-https://www.openhab.org/docs/developer/#setup-the-development-environment
+<https://www.openhab.org/docs/developer/#setup-the-development-environment>
 
 Happy coding!

bom/openhab-addons/pom.xml

@@ -651,11 +651,6 @@
       <artifactId>org.openhab.binding.freeathome</artifactId>
       <version>${project.version}</version>
     </dependency>
-    <dependency>
-      <groupId>org.openhab.addons.bundles</groupId>
-      <artifactId>org.openhab.binding.freebox</artifactId>
-      <version>${project.version}</version>
-    </dependency>
     <dependency>
       <groupId>org.openhab.addons.bundles</groupId>
       <artifactId>org.openhab.binding.freeboxos</artifactId>

bundles/org.openhab.automation.jrubyscripting/src/main/java/org/openhab/automation/jrubyscripting/internal/JRubyConsoleCommandExtension.java

@@ -58,8 +58,8 @@
 public class JRubyConsoleCommandExtension extends AbstractConsoleCommandExtension implements ConsoleCommandCompleter {
     private final Logger logger = LoggerFactory.getLogger(JRubyConsoleCommandExtension.class);
 
-    private final String DEFAULT_CONSOLE_PATH = "openhab/console/";
-    private final String OPENHAB_SCRIPTING_GEM = "gem \"openhab-scripting\", \"~> 5.0\"";
+    private static final String DEFAULT_CONSOLE_PATH = "openhab/console/";
+    private static final String OPENHAB_SCRIPTING_GEM = "gem \"openhab-scripting\", \"~> 5.0\"";
 
     private static final String INFO = "info";
     private static final String CONSOLE = "console";