-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[homekit] New HomeKit client binding #19340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
andrewfg
wants to merge
172
commits into
openhab:main
Choose a base branch
from
andrewfg:homekit-client
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Fiddian-Green <[email protected]>
Signed-off-by: Andrew Fiddian-Green <[email protected]>
Signed-off-by: Andrew Fiddian-Green <[email protected]>
Signed-off-by: Andrew Fiddian-Green <[email protected]>
Signed-off-by: Andrew Fiddian-Green <[email protected]>
…addons into homekit-client
Signed-off-by: Andrew Fiddian-Green <[email protected]>
Signed-off-by: Andrew Fiddian-Green <[email protected]>
Signed-off-by: Andrew Fiddian-Green <[email protected]>
Signed-off-by: Andrew Fiddian-Green <[email protected]>
Signed-off-by: Andrew Fiddian-Green <[email protected]>
Signed-off-by: Andrew Fiddian-Green <[email protected]>
Signed-off-by: Andrew Fiddian-Green <[email protected]>
Signed-off-by: Andrew Fiddian-Green <[email protected]>
Signed-off-by: Andrew Fiddian-Green <[email protected]>
Signed-off-by: Andrew Fiddian-Green <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Signed-off-by: Andrew Fiddian-Green <[email protected]>
Signed-off-by: Andrew Fiddian-Green <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
ThomasM102
approved these changes
Nov 30, 2025
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: Andrew Fiddian-Green <[email protected]>
ceb8a23 to
2c5a98b
Compare
jlaur
reviewed
Dec 1, 2025
Co-authored-by: Jacob Laursen <[email protected]> Signed-off-by: Andrew Fiddian-Green <[email protected]>
- use new core HexUtils functions - add java doc about Alice and Bob notation - eliminate minor compiler warnings Signed-off-by: Andrew Fiddian-Green <[email protected]>
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: Andrew Fiddian-Green <[email protected]>
Signed-off-by: Andrew Fiddian-Green <[email protected]>
Contributor
Author
|
@jlaur I successfully removed the bridge polling and sleep code that you didn't like. And replaced it with a purely event driven model. I have tested this today and I can confirm that it works perfectly. So it is now ready again for your review. EDIT: added resubscription to eventing if a new item channel link is added |
- remove unnecessary handler initialized tests - resubscribe event if channel linked - refactoring Signed-off-by: Andrew Fiddian-Green <[email protected]>
Signed-off-by: Andrew Fiddian-Green <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #14094
There is an existing HomeKit system integration addon which allows exporting OH Items into the HomeKit eco- system.
This is a new HomeKit client binding addon which allows importing OH Things and Channels from the HomeKit eco- system.
There are three types of Things supported:
accessory: This integrates a single HomeKit accessory, which has its own LAN connection.Its services appear as channel groups, and their respective characteristics appear as channels.
bridged-accessory: This integrates a single HomeKit accessory, which does NOT have its own LAN connection.It has the same functionality as an
accessory, except that its communication is done via abridge(see below).bridge: This integrates a HomeKit bridge accessory, which has its own LAN connection.It does not have any own channels.
Instead it contains multiple
bridged-accessoryThings (see above).Things of type
bridgeandaccessoryboth communicate directly with their HomeKit device over the LAN. Whereasbridged-accessoryThings communicate via their respectivebridgeThing.The JAR files for testing purposes are here:
See Apple HomeKit Specification.pdf for reference.
Notes:
Signed-off-by: Andrew Fiddian-Green [email protected]
Todos:
Issues that will NOT be addressed