Skip to content

Request handlers can leak pooled Validator objects #193

@csw

Description

@csw

Some code paths in the request handlers can leak Validator objects obtained from one of the object pools, such as the select_transcripts parameter validation error in /variantvalidator:

return {"Not Found": "Setting select_transcripts to 'all' or 'raw' is deprecated for genomic "

I've worked up a change that retrieves items with a context manager to ensure that they're returned to the pool, and lets the pools grow dynamically up to their configured maximum size: Genomenon@acc8592. Let me know if this seems reasonable, and I'll be happy to make a PR for it.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions