Fix Part of #4938: Create Admin Onboarding Intro(2/12) #5839

adhiamboperes · 2025-06-02T15:52:49Z

Explanation

Fixes part of #4938

This PR creates the introduction screen, where the user is informed about what it means to be an admin.

In #5378, the "I am a parent/Teacher" option previously routed to the profiles list screen, since admin onboarding had not yet been implemented. In this PR, the option leads to the admin creating their profile nickname, followed by viewing the newly introduced introduction screen. The steps are ordered this way for consistency with the learner onboarding flow.

In #5387, supervisor profile onboarding was marked as started on the profile type screen and ended on the home screen. This workaround has now been updated so that supervisor onboarding starts on the introduction screen (similar to the learner flow). This means that if the user abandons onboarding at this point, they will resume the flow from the introduction screen when they reopen the app. Admin onboarding is marked as completed on the profile chooser screen.

This PR also ensures that the onboarding event logs are refactored accordingly, and tests have been updated to verify the refactor.

Additionally, testFragment_profileTypeArgumentMissing_showsUnknownProfileTypeError() has been removed from CreateProfileFragmentTest.kt because this condition will never be hit, due to a new check that verifies ProfileType is not null when a CreateProfileActivity intent is created.

Essential Checklist

The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
Any changes to scripts/assets files have their rationale included in the PR explanation.
The PR follows the style guide.
The PR does not contain any unnecessary code changes from Android Studio (reference).
The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
For PRs introducing new UI elements or color changes, both light and dark mode screenshots must be included
Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

Landscape	Portrait


https://github.com/user-attachments/assets/b1dd5108-f439-4817-bdab-40f676f86d75	https://github.com/user-attachments/assets/c4cf5c05-722d-4d5a-baca-15752cc7b3ee
tablet landscape	tablet_portrait
event_logs.webm

# Conflicts: # app/src/main/res/values/styles.xml

…n-pin-input

…is reset

github-actions · 2025-09-16T00:48:47Z

Coverage Report

Results

Number of files assessed: 23
Overall Coverage: 75.28%
Coverage Analysis: PASS ✅

Passing coverage

Files with passing code coverage

File	Coverage	Lines Hit	Status	Min Required
EventBundleCreator.kt utility/src/main/java/org/oppia/android/util/logging/EventBundleCreator.kt	75.28%	338 / 449	✅	70%

Exempted coverage

Files exempted from coverage

File	Exemption Reason
ActivityComponentImpl.kt app/src/main/java/org/oppia/android/app/activity/ActivityComponentImpl.kt	This file is exempted from having a test file; skipping coverage check.
ProfileChooserFragment.kt app/src/main/java/org/oppia/android/app/profile/ProfileChooserFragment.kt	This file is incompatible with code coverage tooling; skipping coverage check.
ProfileChooserFragmentPresenter.kt app/src/main/java/org/oppia/android/app/profile/ProfileChooserFragmentPresenter.kt	This file is exempted from having a test file; skipping coverage check.
ProfileChooserActivity.kt app/src/main/java/org/oppia/android/app/profile/ProfileChooserActivity.kt	This file is exempted from having a test file; skipping coverage check.
ProfileChooserActivityPresenter.kt app/src/main/java/org/oppia/android/app/profile/ProfileChooserActivityPresenter.kt	This file is exempted from having a test file; skipping coverage check.
FragmentComponentImpl.kt app/src/main/java/org/oppia/android/app/fragment/FragmentComponentImpl.kt	This file is exempted from having a test file; skipping coverage check.
HomeFragmentPresenter.kt app/src/main/java/org/oppia/android/app/home/HomeFragmentPresenter.kt	This file is exempted from having a test file; skipping coverage check.
HomeActivity.kt app/src/main/java/org/oppia/android/app/home/HomeActivity.kt	This file is incompatible with code coverage tooling; skipping coverage check.
SplashActivity.kt app/src/main/java/org/oppia/android/app/splash/SplashActivity.kt	This file is incompatible with code coverage tooling; skipping coverage check.
SplashActivityPresenter.kt app/src/main/java/org/oppia/android/app/splash/SplashActivityPresenter.kt	This file is exempted from having a test file; skipping coverage check.
CreateProfileFragment.kt app/src/main/java/org/oppia/android/app/onboarding/CreateProfileFragment.kt	This file is incompatible with code coverage tooling; skipping coverage check.
AdminIntroActivityPresenter.kt app/src/main/java/org/oppia/android/app/onboarding/AdminIntroActivityPresenter.kt	This file is exempted from having a test file; skipping coverage check.
OnboardingProfileTypeFragmentPresenter.kt app/src/main/java/org/oppia/android/app/onboarding/OnboardingProfileTypeFragmentPresenter.kt	This file is exempted from having a test file; skipping coverage check.
CreateProfileActivity.kt app/src/main/java/org/oppia/android/app/onboarding/CreateProfileActivity.kt	This file is incompatible with code coverage tooling; skipping coverage check.
AdminIntroFragmentPresenter.kt app/src/main/java/org/oppia/android/app/onboarding/AdminIntroFragmentPresenter.kt	This file is exempted from having a test file; skipping coverage check.
WavyBackgroundView.kt app/src/main/java/org/oppia/android/app/onboarding/WavyBackgroundView.kt	This file is exempted from having a test file; skipping coverage check.
CreateProfileFragmentPresenter.kt app/src/main/java/org/oppia/android/app/onboarding/CreateProfileFragmentPresenter.kt	This file is exempted from having a test file; skipping coverage check.
AdminIntroFragment.kt app/src/main/java/org/oppia/android/app/onboarding/AdminIntroFragment.kt	This file is incompatible with code coverage tooling; skipping coverage check.
AdminIntroActivity.kt app/src/main/java/org/oppia/android/app/onboarding/AdminIntroActivity.kt	This file is incompatible with code coverage tooling; skipping coverage check.
OnboardingProfileTypeFragment.kt app/src/main/java/org/oppia/android/app/onboarding/OnboardingProfileTypeFragment.kt	This file is incompatible with code coverage tooling; skipping coverage check.
ClassroomListFragmentPresenter.kt app/src/main/java/org/oppia/android/app/classroom/ClassroomListFragmentPresenter.kt	This file is exempted from having a test file; skipping coverage check.
ClassroomListFragment.kt app/src/main/java/org/oppia/android/app/classroom/ClassroomListFragment.kt	This file is incompatible with code coverage tooling; skipping coverage check.

Refer test_file_exemptions.textproto for the comprehensive list of file exemptions and their required coverage percentages.

To learn more, visit the Oppia Android Code Coverage wiki page

oppiabot · 2025-09-23T00:36:44Z

Hi @adhiamboperes, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

# Conflicts: # app/src/main/AndroidManifest.xml # app/src/main/java/org/oppia/android/app/activity/ActivityComponentImpl.kt # app/src/main/java/org/oppia/android/app/fragment/FragmentComponentImpl.kt # app/src/main/java/org/oppia/android/app/profile/ProfileChooserActivityPresenter.kt # app/src/main/res/values/strings.xml # model/src/main/proto/screens.proto # utility/src/main/java/org/oppia/android/util/logging/EventBundleCreator.kt

adhiamboperes · 2025-09-23T19:00:35Z

Thanks for your initial review @subhajitxyz! I addressed your comments. However, there have been a lot of refactors since your review, and I appreciate that you might not have time to review a second time due to being on a break.

@BenHenning, PTAL.

oppiabot · 2025-09-30T19:51:05Z

Hi @adhiamboperes, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

oppiabot · 2025-10-14T21:16:24Z

Hi @adhiamboperes, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

BenHenning · 2025-10-31T01:08:17Z

Apologies--will try to look at this early next week. Feel free to send me more chained PRs as well if that helps.

oppiabot · 2025-11-07T01:16:08Z

Hi @adhiamboperes, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

BenHenning

Thanks @adhiamboperes! Took a full pass and had just a few comments--PTAL.

BenHenning · 2025-11-09T20:58:40Z

app/src/main/java/org/oppia/android/app/classroom/ClassroomListFragmentPresenter.kt

+        if (enableOnboardingFlowV2.value) {
+          when {
+            profileType == ProfileType.SUPERVISOR && profile.numberOfLogins == 1 -> {
+              // Supervisors end  profile onboarding on the profiles list screen, but they do


Suggested change

// Supervisors end profile onboarding on the profiles list screen, but they do

// Supervisors end profile onboarding on the profiles list screen, but they do

Small nit.

BenHenning · 2025-11-09T21:03:45Z

app/src/main/java/org/oppia/android/app/onboarding/WavyBackgroundView.kt

+import androidx.compose.ui.unit.dp
+import kotlin.math.sin
+
+/** Adds a bezier curve background to a view. */


Slight nit maybe, but is this actually a bezier curve? It appears to be a sine wave, instead.

BenHenning · 2025-11-09T21:06:59Z

app/src/main/java/org/oppia/android/app/splash/SplashActivityPresenter.kt

+          ProfileType.SUPERVISOR -> launchProfileChooserScreen()
+          else -> {}
        }
-        else -> launchOnboardingActivity()


Perhaps we should combine them together so that the else cases are impossible? I do worry a bit about the else cases since they would make the user stuck, I think.

BenHenning · 2025-11-09T21:08:05Z

app/src/main/res/layout/admin_intro_fragment.xml

@@ -0,0 +1,7 @@
+<layout xmlns:android="http://schemas.android.com/apk/res/android">
+    <androidx.compose.ui.platform.ComposeView


For this & app/src/main/res/layout/admin_intro_activity.xml these should be two-space indented.

BenHenning · 2025-11-09T21:23:23Z

app/src/sharedTest/java/org/oppia/android/app/onboarding/AdminIntroFragmentTest.kt

+  @Test
+  fun testIntroFragment_onLaunch_landscapeMode_allViewsAreCorrectlyDisplayed() {
+    launch(AdminIntroActivity::class.java).use {
+      onView(ViewMatchers.isRoot()).perform(orientationLandscape())


This test should start in landscape using a qualifier rather than rotating (since rotating isn't 100% reliable in Robolectric).

Also, shouldn't this verify that the step count isn't visible since that's orientation-specific logic?

oppiabot · 2025-11-09T21:27:58Z

Unassigning @BenHenning since the review is done.

oppiabot · 2025-11-09T21:28:01Z

Hi @adhiamboperes, it looks like some changes were requested on this pull request by @BenHenning. PTAL. Thanks!

adhiamboperes and others added 30 commits March 19, 2025 02:13

New layout for auth

f3e8961

Merge remote-tracking branch 'upstream/develop' into redesign-pin-input

471e1a6

# Conflicts: # app/src/main/res/values/styles.xml

Add compose livedata dependency

14296af

Create color and string resources

cb7936f

Create xml layouts

b10ae81

Create ProfileLoginActivity

5a366f1

Create ProfileLoginFragment

83f3762

Refactor login intent to new ProfileLoginActivity

c384747

Add todos to track cleanup

a691304

Cleanup unused items

eec9434

Add admin reset pin flow

99e1a19

Add route to non-admin reset pin flow

a93542a

Add non-admin pin reset flow

1ea182a

wip commit

69973d1

Merge branch 'develop' of github.com:oppia/oppia-android into redesig…

b393870

…n-pin-input

Create AdminIntroActivity

f00119d

Create AdminIntroFragment

8d6139a

Correct ktlint errors

2796aa4

Add navigation to the screen

3cff4d1

Create the screen components

9145b20

Add navigation to the next screen

44d77bf

Add activity tests

9ef0501

Add fragment tests

734c9ab

Break down large composables

d894646

Add tests for login flow

a0ca9de

Move dialogs to own files

0524005

Add tests for dialog flows: wip for non-admin

3c7e3ff

Add todo to ensure an admin profile is created when all profile data …

a83c10b

…is reset

Fix lint issues

09bfe8c

Fix static analysis checks failures

a4e9208

Fix failing OnboardingProfileTypeFragmentTest tests

054ad99

oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Sep 23, 2025

adhiamboperes removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Sep 23, 2025

Base automatically changed from redesign-pin-input to develop September 23, 2025 17:10

adhiamboperes assigned BenHenning and unassigned adhiamboperes Sep 23, 2025

oppiabot bot assigned subhajitxyz Sep 23, 2025

oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Sep 30, 2025

oppiabot bot closed this Oct 7, 2025

adhiamboperes reopened this Oct 7, 2025

oppiabot bot removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Oct 7, 2025

oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Oct 14, 2025

oppiabot bot closed this Oct 21, 2025

adhiamboperes reopened this Oct 29, 2025

oppiabot bot removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Oct 29, 2025

oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Nov 7, 2025

BenHenning requested changes Nov 9, 2025

View reviewed changes

oppiabot bot removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Nov 9, 2025

oppiabot bot unassigned BenHenning Nov 9, 2025

oppiabot bot assigned adhiamboperes Nov 9, 2025

	// Supervisors end profile onboarding on the profiles list screen, but they do
	// Supervisors end profile onboarding on the profiles list screen, but they do

		@@ -0,0 +1,7 @@
		<layout xmlns:android="http://schemas.android.com/apk/res/android">
		<androidx.compose.ui.platform.ComposeView

Fix Part of #4938: Create Admin Onboarding Intro(2/12) #5839

Are you sure you want to change the base?

Fix Part of #4938: Create Admin Onboarding Intro(2/12) #5839

Uh oh!

Conversation

adhiamboperes commented Jun 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation

Essential Checklist

For UI-specific PRs only

Uh oh!

github-actions bot commented Sep 16, 2025

Coverage Report

Results

Passing coverage

Exempted coverage

Uh oh!

oppiabot bot commented Sep 23, 2025

Uh oh!

adhiamboperes commented Sep 23, 2025

Uh oh!

oppiabot bot commented Sep 30, 2025

Uh oh!

oppiabot bot commented Oct 14, 2025

Uh oh!

BenHenning commented Oct 31, 2025

Uh oh!

oppiabot bot commented Nov 7, 2025

Uh oh!

BenHenning left a comment

Choose a reason for hiding this comment

Uh oh!

BenHenning Nov 9, 2025

Choose a reason for hiding this comment

Uh oh!

BenHenning Nov 9, 2025

Choose a reason for hiding this comment

Uh oh!

BenHenning Nov 9, 2025

Choose a reason for hiding this comment

Uh oh!

BenHenning Nov 9, 2025

Choose a reason for hiding this comment

Uh oh!

BenHenning Nov 9, 2025

Choose a reason for hiding this comment

Uh oh!

oppiabot bot commented Nov 9, 2025

Uh oh!

oppiabot bot commented Nov 9, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

adhiamboperes commented Jun 2, 2025 •

edited

Loading