Fixes #5972: Profile name accepts invalid inputs like single dot (.) or single space ( )

[ShankhanilSaha]

Explanation

Fixes #5972

• Updates utility/src/main/java/org/oppia/android/util/profile/ProfileNameValidator.kt to only allow names which have only alphabets and spaces.
• Now names with single dots(.) and single spaces( ) are not allowed anymore which previously were.

Essential Checklist

• The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
• Any changes to scripts/assets files have their rationale included in the PR explanation.
• The PR follows the style guide.
• The PR does not contain any unnecessary code changes from Android Studio (reference).
• The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
• The PR is assigned to the appropriate reviewers (reference).

[adhiamboperes]

Thanks @ShankhanilSaha! I have reviewed the PR and left some comments. Also, please take a look at the CI results -- tests in ProfileManagementControllerTest are failing due to the changed logic. Please locate the failing tests and either fix them, or verify whether the new logic is working correctly.

Please also reach out if you have any questions.

[ShankhanilSaha]

Hi @adhiamboperes, the tests are primarily failing because of the tests in utility/src/test/java/org/oppia/android/util/profile/ProfileNameValidatorTest.kt
should i completely remove the tests which are verifying names which were formerly allowed? or should i update them to something like the code in the attatchment which will expect false to formerly allowed names.

[ShankhanilSaha]

@adhiamboperes could you please check the error logs once, some tests were failing previously so i fixed them by changing the functions to addAdminProfileAndWait() which fixed the issue of the test looking for a profile before it was even created.
But now it seems like there is some maven related dependency downloading issue which i believe has not arrived from my code, could be wrong.

[theMr17]

@ShankhanilSaha I've re-run the tests, they should work fine now.

[ShankhanilSaha]

@adhiamboperes upon making the file changes in this PR a few tests fail in app/src/sharedTest/java/org/oppia/android/app/onboarding/CreateProfileFragmentTest.kt
and
testing/src/test/java/org/oppia/android/testing/profile/ProfileTestHelperTest.kt even tho tests are unrelated to the changes since they don't use any name which passed previously but gets rejected with the changes. I could use some help with this one.

[adhiamboperes]

Hi @ShankhanilSaha, those tests are failing because they rely on the ProfileManagementController, which relies on the ProfileNameValidator

[adhiamboperes]

Looking at the traces, it appears that the failing functions rely on an exception that has changed, so there are changes needed downstream as well. I need to review the code first.