Merge pull request #218 from oqtopus-team/develop

release: 2025-07-04 15:13

Author: katsujukou

.editorconfig-checker.json

@@ -0,0 +1,6 @@
+{
+  "Exclude": [
+    ".*\\.md$",
+    "backend/alembic/versions/.*\\.py$"
+  ]
+}

.github/workflows/actionlint.yaml

@@ -0,0 +1,24 @@
+name: Actionlint
+
+on:
+  pull_request:
+    paths:
+      - ".github/workflows/**/*.yaml"
+      - ".github/workflows/**/*.yml"
+
+jobs:
+  actionlint:
+    runs-on: ubuntu-latest
+    permissions:
+      checks: "write"
+      contents: "read"
+      pull-requests: "write"
+    steps:
+      - uses: actions/checkout@v4
+      - uses: reviewdog/[email protected]
+        with:
+          github_token: ${{ secrets.GITHUB_TOKEN }}
+          fail_level: error
+          filter_mode: nofilter
+          level: error
+          reporter: github-pr-review

.github/workflows/deployment.yaml

@@ -10,6 +10,7 @@ jobs:
   deployment:
     runs-on: ubuntu-latest
     strategy:
+      fail-fast: false
       matrix:
         deploy-target: [user, provider, admin, lambda_auth, user_signup]
 
@@ -29,7 +30,7 @@ jobs:
       - name: Set AWS Profile
         run: |
           ACCOUNT_NAME=$(aws iam list-account-aliases --query "AccountAliases[0]" --output text)
-          echo "PROFILE=$ACCOUNT_NAME" >> $GITHUB_ENV
+          echo "PROFILE=$ACCOUNT_NAME" >> "$GITHUB_ENV"
 
       - name: Set up Python
         uses: actions/setup-python@v5
@@ -39,14 +40,15 @@ jobs:
       - name: Install Poetry
         run: |
           pip install poetry poetry-plugin-export
-          echo "$HOME/.local/bin" >> $GITHUB_PATH
+          echo "$HOME/.local/bin" >> "$GITHUB_PATH"
 
       - name: Install poetry dependencies
         run: poetry install
 
       - name: Install make
         run: sudo apt install make
 
+
       - name: Deploy
         working-directory: ./deployment/oqtopus-dev
         env:
@@ -57,111 +59,23 @@ jobs:
 
       - name: On Success
         if: ${{ success() }}
-        env:
-          SLACK_API_TOKEN: ${{ secrets.SLACK_API_TOKEN }}
         run: |
-          TIMESTAMP=$(date "+%Y-%m-%d %H:%M:%S")
-          RUN_URL="https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}"
-          curl -s -o /dev/null -X POST https://slack.com/api/chat.postMessage \
-          -H "Content-Type: application/json" \
-          -H "Authorization: Bearer $SLACK_API_TOKEN" \
-          --data @- <<EOF
-          {
-            "channel": "${{ secrets.SLACK_CHANNEL_NAME }}",
-            "text": "✅ Deploy successful (${{ matrix.deploy-target }})",
-            "attachments": [
-              {
-                "color": "#00dd00",
-                "blocks": [
-                  {
-                    "type": "section",
-                    "text": {
-                      "type": "mrkdwn",
-                      "text": "*Log*"
-                    }
-                  },
-                  {
-                    "type": "section",
-                    "text": {
-                      "type": "mrkdwn",
-                      "text": "[${TIMESTAMP}] Deployed successfully!"
-                    }
-                  },
-                  {
-                    "type": "divider"
-                  },
-                  {
-                    "type": "section",
-                    "text": {
-                      "type": "mrkdwn",
-                      "text": "*Action*"
-                    }
-                  },
-                  {
-                    "type": "section",
-                    "text": {
-                      "type": "mrkdwn",
-                      "text": "${RUN_URL}"
-                    }
-                  }
-                ]
-              }
-            ]
-          }
-          EOF
+          echo "SUCCESS=1" >> "$GITHUB_ENV"
 
       - name: On Failure
         if: ${{ failure() }}
+        run: |
+          echo "SUCCESS=0" >> "$GITHUB_ENV"
+
+      - name: On Exit
+        if: ${{ always() }}
+        run: |
+          source .venv/bin/activate
+          python3 ./scripts/build_slack_notification.py \
+            --success="$SUCCESS" \
+            --timestamp="$(date "+%Y-%m-%d %H:%M:%S")" \
+            --run-url="https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}" \
+            --deploy-target="${{ matrix.deploy-target }}"
         env:
           SLACK_API_TOKEN: ${{ secrets.SLACK_API_TOKEN }}
-        run: |
-          TIMESTAMP=$(date "+%Y-%m-%d %H:%M:%S")
-          RUN_URL="https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}"
-          MESSAGE=$(cat error.log)
-          curl -s -o /dev/null -X POST https://slack.com/api/chat.postMessage \
-          -H "Content-Type: application/json" \
-          -H "Authorization: Bearer $SLACK_API_TOKEN" \
-          --data @- <<EOF
-          {
-            "channel": "${{ secrets.SLACK_CHANNEL_NAME }}",
-            "text": "❌ Deploy failed (${{ matrix.deploy-target }})",
-            "attachments": [
-              {
-                "color": "#dd0000",
-                "blocks": [
-                  {
-                    "type": "section",
-                    "text": {
-                      "type": "mrkdwn",
-                      "text": "*Log*"
-                    }
-                  },
-                  {
-                    "type": "section",
-                    "text": {
-                      "type": "mrkdwn",
-                      "text": "[${TIMESTAMP}] Deploy failed!"
-                    }
-                  },
-                  {
-                    "type": "divider"
-                  },
-                  {
-                    "type": "section",
-                    "text": {
-                      "type": "mrkdwn",
-                      "text": "*Action*"
-                    }
-                  },
-                  {
-                    "type": "section",
-                    "text": {
-                      "type": "mrkdwn",
-                      "text": "${RUN_URL}"
-                    }
-                  }
-                ]
-              }
-            ]
-          }
-          EOF
+          SLACK_CHANNEL_NAME: ${{ secrets.SLACK_CHANNEL_NAME }}

.github/workflows/editorconfig-review.yaml

@@ -0,0 +1,44 @@
+name: Code review
+
+on:
+  pull_request:
+    branches:
+      - develop
+
+permissions:
+  contents: read
+  pull-requests: write
+
+
+jobs:
+  review:
+    runs-on: ubuntu-latest
+    steps:
+      - name: check out
+        uses: actions/checkout@v4
+
+      - name: Setup reviewdog
+        uses: reviewdog/action-setup@v1
+        with:
+          reviewdog_version: latest
+
+      - name: Define envs
+        run: |
+          echo "OS=linux" >> "$GITHUB_ENV"
+          echo "ARCH=amd64" >> "$GITHUB_ENV"
+
+      - name: Install editorconfig-checker
+        run: |
+          VERSION="v3.3.0"
+
+          curl -fsSL https://github.com/editorconfig-checker/editorconfig-checker/releases/download/${VERSION}/ec-${{ env.OS }}-${{ env.ARCH }}.tar.gz  -o ec.tar.gz
+          tar -xzf ec.tar.gz
+          chmod -R +x bin
+
+      - name: Run editorconfig-checker with reviewdog
+        run: |
+          bin/ec-${{ env.OS }}-${{ env.ARCH }} -config .editorconfig-checker.json > output_ecc.txt || true
+          python3 scripts/ecc_converter.py < output_ecc.txt > result_py.txt
+          reviewdog -efm="%f:%l:%c: %m" -name="editorconfig-checker" -reporter=github-pr-review < result_py.txt
+        env:
+          REVIEWDOG_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/labeler.yaml

@@ -60,17 +60,19 @@ jobs:
           echo "$unique_labels"
 
           # Set the output as a newline-separated string
-          echo "labels<<EOF" >> $GITHUB_OUTPUT
-          echo "$unique_labels" >> $GITHUB_OUTPUT
-          echo "EOF" >> $GITHUB_OUTPUT
+          {
+            echo "labels<<EOF"
+            echo "$unique_labels"
+            echo "EOF"
+          } >> "$GITHUB_OUTPUT"
 
       - name: Add labels to PR
         uses: actions-ecosystem/action-add-labels@v1
         with:
           labels: ${{ steps.set-labels.outputs.labels }}
 
       - name: Assign PR creator
-        uses: actions/github-script@v6
+        uses: actions/github-script@v7
         with:
           script: |
             await github.rest.issues.addAssignees({

.github/workflows/prod-cd.yaml

@@ -27,7 +27,7 @@ jobs:
       - name: Set AWS Profile
         run: |
           ACCOUNT_NAME=$(aws iam list-account-aliases --query "AccountAliases[0]" --output text)
-          echo "PROFILE=$ACCOUNT_NAME" >> $GITHUB_ENV
+          echo "PROFILE=$ACCOUNT_NAME" >> "$GITHUB_ENV"
 
 
       - name: Set up Python
@@ -38,7 +38,7 @@ jobs:
       - name: Install Poetry
         run: |
           pip install poetry poetry-plugin-export
-          echo "$HOME/.local/bin" >> $GITHUB_PATH
+          echo "$HOME/.local/bin" >> "$GITHUB_PATH"
 
       - name: Install poetry dependencies
         run: poetry install
@@ -114,7 +114,6 @@ jobs:
         run: |
           TIMESTAMP=$(date "+%Y-%m-%d %H:%M:%S")
           RUN_URL="https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}"
-          MESSAGE=$(cat error.log)
           curl -s -o /dev/null -X POST https://slack.com/api/chat.postMessage \
           -H "Content-Type: application/json" \
           -H "Authorization: Bearer $SLACK_API_TOKEN" \

.github/workflows/tflint.yaml

@@ -15,7 +15,7 @@ jobs:
 
     steps:
       - name: Checkout repository
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
       - name: Set up Aqua
         uses: aquaproj/[email protected]

.github/workflows/update-document.yaml

@@ -26,7 +26,7 @@ jobs:
       run: |
         git config --global user.name "github-actions[bot]"
         git config --global user.email "github-actions[bot]@users.noreply.github.com"
-  
+
     - name: Set up Python
       uses: actions/setup-python@v5
       with:
@@ -35,7 +35,7 @@ jobs:
     - name: Install Poetry
       run: |
         pip install poetry poetry-plugin-export
-        echo "$HOME/.local/bin" >> $GITHUB_PATH
+        echo "$HOME/.local/bin" >> "$GITHUB_PATH"
 
     - name: Install poetry dependencies
       run: poetry install
@@ -54,8 +54,8 @@ jobs:
     - name: Create new branch and switch
       run: |
         BRANCH_NAME="chore/auto-update-docs-$(date +%Y%m%d-%H%M%S)"
-        git checkout -b $BRANCH_NAME
-        echo "BRANCH_NAME=$BRANCH_NAME" >> $GITHUB_ENV
+        git checkout -b "$BRANCH_NAME"
+        echo "BRANCH_NAME=$BRANCH_NAME" >> "$GITHUB_ENV"
 
     - name: Auto PR
       env:
@@ -67,9 +67,9 @@ jobs:
           exit 0
         fi
         git commit -m "Auto update document $(date +%Y%m%d-%H%M%S)" -a
-        git push origin $BRANCH_NAME
+        git push origin "$BRANCH_NAME"
         gh pr create --title "chore: [CI] Auto update document $(date +%Y%m%d-%H%M%S)" \
                       --body "This PR was automatically generated.$TRIGGERED_PUSH_URL" \
                       --base develop \
-                      --head $BRANCH_NAME \
+                      --head "$BRANCH_NAME" \
                       --label documentation

.github/workflows/update-poetry-lock.yaml

@@ -20,7 +20,7 @@ jobs:
       - name: Install Poetry
         run: |
           pip install poetry poetry-plugin-export
-          echo "$HOME/.local/bin" >> $GITHUB_PATH
+          echo "$HOME/.local/bin" >> "$GITHUB_PATH"
 
       - name: Update poetry.lock
         run: |
@@ -44,9 +44,9 @@ jobs:
             exit 0
           fi
           git commit -m "Auto update poetry.lock $(date +%Y%m%d-%H%M%S)" -a
-          git push origin $BRANCH_NAME
+          git push origin "$BRANCH_NAME"
           gh pr create --title "chore: [CI] Auto update poetry.lock $(date +%Y%m%d-%H%M%S)" \
                         --body "This PR was automatically generated: $TRIGGERED_PUSH_URL" \
                         --base develop \
-                        --head $BRANCH_NAME \
+                        --head "$BRANCH_NAME" \
                         --label ci

.github/workflows/update_version.yaml

@@ -16,11 +16,13 @@ jobs:
 
       - name: Extract version from comment
         id: extract_version
+        env:
+          COMMENT_BODY: ${{ github.event.comment.body }}
         run: |
-          echo "Requested comment: ${{ github.event.comment.body }}"
-          VERSION=$(echo "${{ github.event.comment.body }}" | sed 's/update-version=//')
+          echo "Requested comment: $COMMENT_BODY"
+          VERSION="${COMMENT_BODY//update-version=}"
           echo "VERSION: $VERSION"
-          echo "::set-output name=version::$VERSION"
+          echo "version=$VERSION" >> "$GITHUB_OUTPUT"
 
       - name: Set up Python
         uses: actions/setup-python@v5
@@ -30,7 +32,7 @@ jobs:
       - name: Install Poetry
         run: |
           pip install poetry poetry-plugin-export
-          echo "$HOME/.local/bin" >> $GITHUB_PATH
+          echo "$HOME/.local/bin" >> "$GITHUB_PATH"
 
       - name: Update version in pyproject.toml
         run: |