refactor(pci-project): fix linter issues

FabienHenon · FabienHenon · commit 6f5bf135541d · 2025-11-26T17:55:22.000+01:00
ref: #MANAGER-20320

Signed-off-by: Fabien Henon &lt;fabien.henon.ext@corp.ovh.com&gt;
diff --git a/packages/manager/apps/pci-project/src/components/activation-guard/ActivationGuard.tsx b/packages/manager/apps/pci-project/src/components/activation-guard/ActivationGuard.tsx
@@ -3,6 +3,8 @@ import { lazy, useMemo } from 'react';
 import { isDiscoveryProject, useProject } from '@ovh-ux/manager-pci-common';
 import { RedirectionGuard } from '@ovh-ux/manager-react-components';
 
+import { TProject } from '@/types/pci-common.types';
+
 const ActivatePage = lazy(() => import('@/pages/detail/activate/Activate.page'));
 
 /**
@@ -12,13 +14,18 @@ const ActivatePage = lazy(() => import('@/pages/detail/activate/Activate.page'))
  * @returns RedirectionGuard component with ActivatePage as child
  */
 export default function ActivationGuard() {
-  const { data: project, isLoading } = useProject();
+  const { data: project, isLoading } = (
+    useProject as unknown as () => {
+      data: TProject | undefined;
+      isLoading: boolean;
+    }
+  )();
 
   const isAlreadyActivated = useMemo(() => {
     if (!project) {
       return false;
     }
-    return !isDiscoveryProject(project);
+    return !(isDiscoveryProject as (project: TProject) => boolean)(project);
   }, [project]);
 
   return (
diff --git a/packages/manager/apps/pci-project/src/components/activation-guard/__tests__/ActivationGuard.spec.tsx b/packages/manager/apps/pci-project/src/components/activation-guard/__tests__/ActivationGuard.spec.tsx
@@ -2,7 +2,7 @@ import { Navigate } from 'react-router-dom';
 
 import { UseQueryResult } from '@tanstack/react-query';
 import { render, screen, waitFor } from '@testing-library/react';
-import { beforeEach, describe, expect, it, vi } from 'vitest';
+import { Mock, beforeEach, describe, expect, it, vi } from 'vitest';
 
 import { isDiscoveryProject, useProject } from '@ovh-ux/manager-pci-common';
 
@@ -12,7 +12,9 @@ import { createWrapper } from '@/wrapperRenders';
 import ActivationGuard from '../ActivationGuard';
 
 vi.mock('@ovh-ux/manager-pci-common', async (importOriginal) => {
-  const actual: typeof import('@ovh-ux/manager-pci-common') = await importOriginal();
+  const actual = (await importOriginal<
+    typeof import('@ovh-ux/manager-pci-common')
+  >()) as unknown as Record<string, unknown>;
   return {
     ...actual,
     useProject: vi.fn(),
@@ -38,7 +40,7 @@ describe('ActivationGuard', () => {
   });
 
   it('should show spinner when project data is loading', () => {
-    vi.mocked(useProject).mockReturnValue({
+    (useProject as unknown as Mock).mockReturnValue({
       data: undefined,
       isLoading: true,
     } as UseQueryResult<TProject, ResponseAPIError>);
@@ -55,12 +57,12 @@ describe('ActivationGuard', () => {
       planCode: 'project.discovery',
     } as TProject;
 
-    vi.mocked(useProject).mockReturnValue({
+    (useProject as unknown as Mock).mockReturnValue({
       data: discoveryProject,
       isLoading: false,
     } as UseQueryResult<TProject, ResponseAPIError>);
 
-    vi.mocked(isDiscoveryProject).mockReturnValue(true);
+    (isDiscoveryProject as unknown as Mock).mockReturnValue(true);
 
     render(<ActivationGuard />, { wrapper: createWrapper() });
 
@@ -77,20 +79,20 @@ describe('ActivationGuard', () => {
       planCode: 'project.2018',
     } as TProject;
 
-    vi.mocked(useProject).mockReturnValue({
+    (useProject as unknown as Mock).mockReturnValue({
       data: activatedProject,
       isLoading: false,
     } as UseQueryResult<TProject, ResponseAPIError>);
 
-    vi.mocked(isDiscoveryProject).mockReturnValue(false);
+    (isDiscoveryProject as unknown as Mock).mockReturnValue(false);
 
     render(<ActivationGuard />, { wrapper: createWrapper() });
 
     expect(Navigate).toHaveBeenCalledWith({ to: '..' }, {});
   });
 
   it('should not redirect when project data is undefined', async () => {
-    vi.mocked(useProject).mockReturnValue({
+    (useProject as unknown as Mock).mockReturnValue({
       data: undefined,
       isLoading: false,
     } as UseQueryResult<TProject, ResponseAPIError>);
diff --git a/packages/manager/apps/pci-project/src/components/project-validation-guard/ProjectValidationGuard.tsx b/packages/manager/apps/pci-project/src/components/project-validation-guard/ProjectValidationGuard.tsx
@@ -1,12 +1,17 @@
 import { ReactNode } from 'react';
 
+import { UseQueryResult } from '@tanstack/react-query';
+
 import { useProject } from '@ovh-ux/manager-pci-common';
 import { RedirectionGuard } from '@ovh-ux/manager-react-components';
 
 import { urls } from '@/routes/routes.constant';
+import { ResponseAPIError, TProject } from '@/types/pci-common.types';
 
 export function ProjectValidationGuard({ children }: { children: ReactNode }) {
-  const { isLoading, isError } = useProject();
+  const { isLoading, isError } = (
+    useProject as unknown as () => UseQueryResult<TProject, ResponseAPIError>
+  )();
   return (
     <>
       <RedirectionGuard condition={isError} isLoading={isLoading} route={urls.root}>
diff --git a/packages/manager/apps/pci-project/src/hooks/home/useProjectIdInLinks.ts b/packages/manager/apps/pci-project/src/hooks/home/useProjectIdInLinks.ts
@@ -9,7 +9,7 @@ import { usePciUrl } from '@ovh-ux/manager-pci-common';
  * @returns Array of items with links containing actual project ID
  */
 export const useProjectIdInLinks = <T extends { link?: string }>(items: T[]): T[] => {
-  const basePciUrl = usePciUrl(); // Returns '#/pci/projects/{actualId}'
+  const basePciUrl = (usePciUrl as unknown as () => string)(); // Returns '#/pci/projects/{actualId}'
 
   return useMemo(
     () =>
diff --git a/packages/manager/apps/pci-project/src/pages/detail/activate/Activate.page.tsx b/packages/manager/apps/pci-project/src/pages/detail/activate/Activate.page.tsx
@@ -33,6 +33,7 @@ import DiscoveryVoucher from '@/pages/creation/components/voucher/DiscoveryVouch
 import Voucher from '@/pages/creation/components/voucher/Voucher';
 import { useWillPayment } from '@/pages/creation/hooks/useWillPayment';
 import { useWillPaymentConfig } from '@/pages/creation/hooks/useWillPaymentConfig';
+import { TProject } from '@/types/pci-common.types';
 
 import { useProjectActivation } from './hooks/useActivateProject';
 
@@ -56,7 +57,7 @@ export default function ActivatePage() {
   const user = environment.getUser();
   const ovhSubsidiary = user.ovhSubsidiary as OvhSubsidiary;
 
-  const { data: project } = useProject();
+  const { data: project } = (useProject as unknown as () => { data: TProject | undefined })();
   const hrefProject = useHref('..');
 
   const { mutate: orderProjectItem, data: projectItem } = useOrderProjectItem();
diff --git a/packages/manager/apps/pci-project/src/pages/home/Header.page.tsx b/packages/manager/apps/pci-project/src/pages/home/Header.page.tsx
@@ -20,6 +20,7 @@ import { BaseLayout, ChangelogButton } from '@ovh-ux/manager-react-components';
 import { ProjectValidationGuard } from '@/components/project-validation-guard/ProjectValidationGuard';
 import { CHANGELOG_LINKS } from '@/constants';
 import { useProjectTabs } from '@/hooks/useProjectTabs';
+import { TProject } from '@/types/pci-common.types';
 
 import QuotaAlert from './components/QuotaAlert.component';
 
@@ -33,11 +34,16 @@ export default function ProjectHeader() {
     NAMESPACES.FORM,
   ]);
 
-  const hrefProject = usePciUrl();
-  const { data: project, isLoading } = useProject();
+  const hrefProject = (usePciUrl as unknown as () => string)();
+  const { data: project, isLoading } = (
+    useProject as unknown as () => {
+      data: TProject | undefined;
+      isLoading: boolean;
+    }
+  )();
   const tabs = useProjectTabs();
 
-  const isDiscovery = isDiscoveryProject(project);
+  const isDiscovery = (isDiscoveryProject as (p: TProject | undefined) => boolean)(project);
 
   return (
     <ProjectValidationGuard>
diff --git a/packages/manager/apps/pci-project/src/pages/home/Home.page.tsx b/packages/manager/apps/pci-project/src/pages/home/Home.page.tsx
@@ -10,10 +10,11 @@ import DocumentationTile from '@/pages/home/components/DocumentationTile.compone
 import Others from '@/pages/home/components/Others.component';
 import QuickAccess from '@/pages/home/components/QuickAccess.component';
 import ActivateProjectModal from '@/pages/home/components/activate-project-modal/ActivateProject';
+import { TProject } from '@/types/pci-common.types';
 
 export default function Home() {
-  const { data: project } = useProject();
-  const isDiscovery = project ? isDiscoveryProject(project) : false;
+  const { data: project } = (useProject as unknown as () => { data: TProject | undefined })();
+  const isDiscovery = project ? (isDiscoveryProject as (p: TProject) => boolean)(project) : false;
 
   return (
     <>
diff --git a/packages/manager/apps/pci-project/src/pages/home/components/QuotaAlert.component.tsx b/packages/manager/apps/pci-project/src/pages/home/components/QuotaAlert.component.tsx
@@ -11,21 +11,26 @@ import { ShellContext } from '@ovh-ux/manager-react-shell-client';
 import { QUOTA_LIMIT_GUIDES } from '@/constants';
 import { useIsQuotaAboveThreshold, useQuotas } from '@/data/hooks/useQuota';
 import { useProjectIdFromParams } from '@/hooks/useProjectIdFromParams';
+import { TProject } from '@/types/pci-common.types';
 
 export default function QuotaAlert() {
   const { t } = useTranslation('home');
   const projectId = useProjectIdFromParams();
 
   const { data: quotas, isLoading } = useQuotas(projectId);
   const isQuotaAboveThreshold = useIsQuotaAboveThreshold(quotas ?? []);
-  const { data: project } = useProject(projectId);
-  const isDiscovery = isDiscoveryProject(project);
+  const { data: project } = (
+    useProject as unknown as (id: string | undefined) => {
+      data: TProject | undefined;
+    }
+  )(projectId);
+  const isDiscovery = (isDiscoveryProject as (p: TProject | undefined) => boolean)(project);
   const { ovhSubsidiary } = useContext(ShellContext).environment.getUser();
 
   const quotaGuidesLink =
     QUOTA_LIMIT_GUIDES[ovhSubsidiary as OvhSubsidiary] || QUOTA_LIMIT_GUIDES.DEFAULT || '';
 
-  const hrefProject = usePciUrl();
+  const hrefProject = (usePciUrl as unknown as () => string)();
   const quotaUrl = `${hrefProject}/quota`;
 
   if (isLoading || !isQuotaAboveThreshold || isDiscovery) {
diff --git a/packages/manager/apps/pci-project/src/pages/home/components/__tests__/QuotaAlert.component.spec.tsx b/packages/manager/apps/pci-project/src/pages/home/components/__tests__/QuotaAlert.component.spec.tsx
@@ -1,5 +1,5 @@
 import { render } from '@testing-library/react';
-import { beforeEach, describe, expect, it, vi } from 'vitest';
+import { Mock, beforeEach, describe, expect, it, vi } from 'vitest';
 
 import { isDiscoveryProject } from '@ovh-ux/manager-pci-common';
 
@@ -35,7 +35,9 @@ vi.mock('react-i18next', async (importOriginal) => {
 
 // Mock usePciUrl to return the expected URL
 vi.mock('@ovh-ux/manager-pci-common', async () => {
-  const actual = await vi.importActual('@ovh-ux/manager-pci-common');
+  const actual = (await vi.importActual<typeof import('@ovh-ux/manager-pci-common')>(
+    '@ovh-ux/manager-pci-common',
+  )) as unknown as Record<string, unknown>;
   return {
     ...actual,
     usePciUrl: vi.fn(() => '#/pci/projects/123'),
@@ -66,7 +68,7 @@ describe('QuotaAlert.component', () => {
       isLoading,
     } as unknown as ReturnType<typeof useQuotas>);
     vi.mocked(useIsQuotaAboveThreshold).mockReturnValue(isAbove);
-    vi.mocked(isDiscoveryProject).mockReturnValue(isDiscovery);
+    (isDiscoveryProject as unknown as Mock).mockReturnValue(isDiscovery);
   };
 
   it('does not render while quotas are loading', () => {
@@ -75,7 +77,7 @@ describe('QuotaAlert.component', () => {
       isLoading: true,
     } as unknown as ReturnType<typeof useQuotas>);
     vi.mocked(useIsQuotaAboveThreshold).mockReturnValue(false);
-    vi.mocked(isDiscoveryProject).mockReturnValue(false);
+    (isDiscoveryProject as unknown as Mock).mockReturnValue(false);
 
     const { container } = render(<QuotaAlert />, { wrapper });
     expect(container.firstChild).toBeNull();
@@ -87,7 +89,7 @@ describe('QuotaAlert.component', () => {
       isLoading: false,
     } as unknown as ReturnType<typeof useQuotas>);
     vi.mocked(useIsQuotaAboveThreshold).mockReturnValue(false);
-    vi.mocked(isDiscoveryProject).mockReturnValue(false);
+    (isDiscoveryProject as unknown as Mock).mockReturnValue(false);
 
     const { container } = render(<QuotaAlert />, { wrapper });
     expect(container.firstChild).toBeNull();
@@ -99,7 +101,7 @@ describe('QuotaAlert.component', () => {
       isLoading: false,
     } as unknown as ReturnType<typeof useQuotas>);
     vi.mocked(useIsQuotaAboveThreshold).mockReturnValue(true);
-    vi.mocked(isDiscoveryProject).mockReturnValue(true);
+    (isDiscoveryProject as unknown as Mock).mockReturnValue(true);
 
     const { container } = render(<QuotaAlert />, { wrapper });
     expect(container.firstChild).toBeNull();
diff --git a/packages/manager/apps/pci-project/src/pages/home/edit/Edit.page.tsx b/packages/manager/apps/pci-project/src/pages/home/edit/Edit.page.tsx
@@ -11,15 +11,16 @@ import {
   useIsAValidHdsSupportLevel,
   useIsHdsFeatureAvailabilityEnabled,
 } from '@/hooks/use-hds/useHds';
+import { TProject } from '@/types/pci-common.types';
 
 import GeneralInformationSection from './general-information-section/GeneralInformationSection';
 import HdsSection from './hds-section/HdsSection';
 import RemoveSection from './remove-section/RemoveSection';
 
 export default function EditPage() {
-  const { data: project } = useProject();
+  const { data: project } = (useProject as unknown as () => { data: TProject | undefined })();
 
-  const isDiscovery = isDiscoveryProject(project);
+  const isDiscovery = (isDiscoveryProject as (p: TProject | undefined) => boolean)(project);
   const isHdsFeatureAvailabilityEnabled = useIsHdsFeatureAvailabilityEnabled();
   const isAValidHdsSupportLevel = useIsAValidHdsSupportLevel();
 
diff --git a/packages/manager/apps/pci-project/src/pages/listing/Listing.tsx b/packages/manager/apps/pci-project/src/pages/listing/Listing.tsx
@@ -84,7 +84,12 @@ export default function Listing() {
     },
   });
 
-  const trustedZoneResult = useTrustedZoneBanner();
+  const trustedZoneResult = (
+    useTrustedZoneBanner as unknown as () => {
+      isBannerVisible?: boolean;
+      isLoading?: boolean;
+    }
+  )();
   const isTrustedZone =
     (trustedZoneResult as { isBannerVisible?: boolean })?.isBannerVisible ?? false;
   const isTrustedZoneLoading = (trustedZoneResult as { isLoading?: boolean })?.isLoading ?? false;
diff --git a/packages/manager/apps/pci-project/src/pages/onboarding/DiscoveryGuard.component.tsx b/packages/manager/apps/pci-project/src/pages/onboarding/DiscoveryGuard.component.tsx
@@ -14,6 +14,7 @@ import { PlanCode } from '@/data/types/Cart.type';
 import { TEligibilityPaymentMethod } from '@/data/types/Eligibility.type';
 import { TProjectWithService } from '@/data/types/Project.type';
 import { urls } from '@/routes/routes.constant';
+import { TProject } from '@/types/pci-common.types';
 
 export default function DiscoveryGuard({ children }: { children: ReactNode }) {
   const navigate = useNavigate();
@@ -68,7 +69,8 @@ export default function DiscoveryGuard({ children }: { children: ReactNode }) {
     }
 
     // If user already have projects, show discovery or default as priority.
-    const discoveryProject = activeProjects.find((d) => isDiscoveryProject(d)) || null;
+    const discoveryProject =
+      activeProjects.find((d) => (isDiscoveryProject as (p: TProject) => boolean)(d)) || null;
     const defaultProject = activeProjects.find((d) => d.isDefault) || null;
     if (discoveryProject || defaultProject) {
       goToProject((discoveryProject || defaultProject) as TProjectWithService);
diff --git a/packages/manager/apps/pci-project/src/pages/onboarding/__tests__/DiscoveryGuard.component.spec.tsx b/packages/manager/apps/pci-project/src/pages/onboarding/__tests__/DiscoveryGuard.component.spec.tsx
@@ -30,7 +30,9 @@ vi.mock('@ovhcloud/ods-components/react', async () => {
   };
 });
 vi.mock('@ovh-ux/manager-pci-common', async (importOriginal) => {
-  const actual: typeof import('@ovh-ux/manager-pci-common') = await importOriginal();
+  const actual = (await importOriginal<
+    typeof import('@ovh-ux/manager-pci-common')
+  >()) as unknown as Record<string, unknown>;
   // Needed to clear the mocked version of 'isDiscoveryProject'
   return {
     ...actual,
diff --git a/packages/manager/apps/pci-project/src/pages/remove/Remove.page.tsx b/packages/manager/apps/pci-project/src/pages/remove/Remove.page.tsx
@@ -17,6 +17,7 @@ import { useIsDefaultProject, useRemoveProjectMutation } from '@/data/hooks/useP
 import { useHasActiveOrPendingSavingsPlan } from '@/data/hooks/useSavingsPlans';
 import { useProjectIdFromParams } from '@/hooks/useProjectIdFromParams';
 import { PROJECTS_TRACKING } from '@/tracking.constant';
+import { TProject } from '@/types/pci-common.types';
 
 type ApiError = AxiosError<{ message: string }>;
 
@@ -36,7 +37,11 @@ export default function RemovePage() {
   const { ovhSubsidiary } = environment?.getUser();
   const region = environment?.getRegion();
 
-  const { data: project } = useProject(projectId);
+  const { data: project } = (
+    useProject as unknown as (id: string) => {
+      data: TProject | undefined;
+    }
+  )(projectId);
 
   const { data: availability } = useFeatureAvailability([FEATURE_AVAILABILITY.SAVINGS_PLAN]);
 
@@ -128,7 +133,7 @@ export default function RemovePage() {
     if (hasActiveOrPendingSavingPlan) {
       return t('pci_projects_project_discovery_edit_savings_plan');
     }
-    if (isDiscoveryProject(project)) {
+    if ((isDiscoveryProject as (p: TProject | undefined) => boolean)(project)) {
       return t('pci_projects_project_discovery_edit_remove_please_note');
     }
     return t('pci_projects_project_edit_remove_please_note');
diff --git a/packages/manager/apps/pci-project/src/setupTests.tsx b/packages/manager/apps/pci-project/src/setupTests.tsx
@@ -59,7 +59,9 @@ vi.mock('react-router-dom', async (importOriginal) => {
 });
 
 vi.mock('@ovh-ux/manager-pci-common', async (importOriginal) => {
-  const actual: typeof import('@ovh-ux/manager-pci-common') = await importOriginal();
+  const actual = (await importOriginal<
+    typeof import('@ovh-ux/manager-pci-common')
+  >()) as unknown as Record<string, unknown>;
   return {
     ...actual,
     isDiscoveryProject: vi.fn(),
