Expose redirect path in RequestRedirect #3001
Open
+18
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we raise the RequestRedirect exception we have already computed the new url that should be redirected to in the exception (new_url) but we don't pass the the new path that we used to compute the url. This causes another layer of redirection in depending code that needs to urlparse() the url to get the path we already have the data for. This adds new_path to the RequestRedirect exception and populates it with the path used when computing new_url. Fixes: pallets#3000
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we raise the RequestRedirect exception
we have already computed the new url that
should be redirected to in the exception
(new_url) but we don't pass the the
new path that we used to compute the url.
This causes another layer of redirection
in depending code that needs to urlparse()
the url to get the path we already have
the data for.
This adds new_path to the RequestRedirect
exception and populates it with the path
used when computing new_url.
Fixes: #3000