This repository was archived by the owner on Oct 5, 2018. It is now read-only.
combineChunks: prevent reading the output file#3
Closed
maclav3 wants to merge 1 commit into
Closed
Conversation
In combineChunks(), the (usually incomplete) output file could be read and written into itself, increasing output file size and sometimes corrupting the file. Moved the check before ioutil.Readfile to prevent this.
Author
|
This is a duplicate of #1, but github.com/fzerorubigd/gongflow doesn't compile on go1.6 - unknown package "http" is imported, in addition to "net/http". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In combineChunks(), the (usually incomplete) output file could be read and written into itself, increasing output file size and sometimes corrupting the file. Moved the check before ioutil.Readfile to prevent this.