set_up_integtest_workspace helper

Author: patrickhyw

env/integtest_pg_conn.py

@@ -6,6 +6,7 @@
     ENV_INTEGTESTS_DBGYM_CONFIG_FPATH,
     INTEGTEST_DBGYM_CFG,
     get_integtest_workspace_path,
+    set_up_integtest_workspace,
 )
 from env.pg_conn import PostgresConn
 from util.pg import (
@@ -30,9 +31,7 @@ class PostgresConnTests(unittest.TestCase):
 
     @staticmethod
     def setUpClass() -> None:
-        # If you're running the test locally, this check makes runs past the first one much faster.
-        if not get_integtest_workspace_path().exists():
-            subprocess.run(["./env/set_up_env_integtests.sh"], check=True)
+        set_up_integtest_workspace()
 
     def setUp(self) -> None:
         self.assertFalse(

env/integtest_tuning_agent.py

@@ -2,7 +2,7 @@
 import unittest
 from typing import Any, Optional
 
-from env.integtest_util import INTEGTEST_DBGYM_CFG, get_integtest_workspace_path
+from env.integtest_util import INTEGTEST_DBGYM_CFG, get_integtest_workspace_path, set_up_integtest_workspace
 from env.tuning_agent import DBMSConfigDelta, TuningAgent
 
 
@@ -22,9 +22,7 @@ def _step(self) -> DBMSConfigDelta:
 class PostgresConnTests(unittest.TestCase):
     @staticmethod
     def setUpClass() -> None:
-        # If you're running the test locally, this check makes runs past the first one much faster.
-        if not get_integtest_workspace_path().exists():
-            subprocess.run(["./env/set_up_env_integtests.sh"], check=True)
+        set_up_integtest_workspace()
 
     @staticmethod
     def make_config(letter: str) -> DBMSConfigDelta:

env/integtest_util.py

@@ -1,4 +1,5 @@
 from pathlib import Path
+import subprocess
 
 import yaml
 
@@ -8,6 +9,12 @@
 INTEGTEST_DBGYM_CFG = DBGymConfig(ENV_INTEGTESTS_DBGYM_CONFIG_FPATH)
 
 
+def set_up_integtest_workspace() -> None:
+    # This if statement prevents us from setting up the workspace twice, which saves time.
+    if not get_integtest_workspace_path().exists():
+        subprocess.run(["./env/set_up_env_integtests.sh"], check=True)
+
+
 def get_integtest_workspace_path() -> Path:
     with open(ENV_INTEGTESTS_DBGYM_CONFIG_FPATH) as f:
         return Path(yaml.safe_load(f)["dbgym_workspace_path"])