Add support for ^php8

Author: Maxim Usenko

composer.json

@@ -12,7 +12,7 @@
         }
     ],
     "require": {
-        "php": ">=5.3.0",
+        "php": "^7.4||^8.0",
         "ext-curl": "*"
     },
     "require-dev": {

lib/PayPal/Common/PPReflectionUtil.php

@@ -47,7 +47,7 @@ public static function getPropertyClass($class, $propertyName)
     public static function propertyAnnotations($class, $propertyName)
     {
         $class = is_object($class) ? get_class($class) : $class;
-        if (!class_exists('ReflectionProperty')) {
+        if (!class_exists(\ReflectionProperty::class)) {
             throw new \RuntimeException("Property type of " . $class . "::{$propertyName} cannot be resolved");
         }
 

lib/PayPal/Core/PPCredentialManager.php

@@ -47,6 +47,7 @@ public static function getInstance($config)
      */
     private function initCredential($config)
     {
+        $searchKey = null;
         $suffix = 1;
         $prefix = "acct";
         if (array_key_exists($prefix, $config)) {

lib/PayPal/Core/PPHttpConfig.php

@@ -48,7 +48,7 @@ public function __construct($url = null, $method = self::HTTP_POST, $configs = a
     {
         $this->url         = $url;
         $this->method      = $method;
-        $this->curlOptions = $this->getHttpConstantsFromConfigs($configs, 'http.') + self::$DEFAULT_CURL_OPTS;
+        $this->curlOptions = $this->getHttpConstantsFromConfigs('http.', $configs) + self::$DEFAULT_CURL_OPTS;
         // Update the Cipher List based on OpenSSL or NSS settings
         $curl       = curl_version();
         $sslVersion = isset($curl['ssl_version']) ? $curl['ssl_version'] : '';
@@ -217,7 +217,7 @@ public function setUserAgent($userAgentString)
      *
      * @return array
      */
-    public function getHttpConstantsFromConfigs($configs = array(), $prefix)
+    public function getHttpConstantsFromConfigs($prefix, $configs = array())
     {
         $arr = array();
         if ($prefix != null && is_array($configs)) {

lib/PayPal/Core/PPUtils.php

@@ -185,7 +185,7 @@ public static function filterKeyPrefix(array $map, $keyPrefix)
     }
 
     /**
-     * @var array|ReflectionProperty[]
+     * @var array|\ReflectionProperty[]
      */
     private static $propertiesRefl = array();
 
@@ -200,13 +200,13 @@ public static function filterKeyPrefix(array $map, $keyPrefix)
      * @param string $class
      * @param string $propertyName
      *
-     * @throws RuntimeException
+     * @throws \RuntimeException
      * @return string
      */
     public static function propertyAnnotations($class, $propertyName)
     {
         $class = is_object($class) ? get_class($class) : $class;
-        if (!class_exists('ReflectionProperty')) {
+        if (!class_exists(\ReflectionProperty::class)) {
             throw new \RuntimeException("Property type of " . $class . "::{$propertyName} cannot be resolved");
         }
 

lib/PayPal/Core/PPXmlFaultMessage.php

@@ -30,11 +30,6 @@ public function init(array $data = array())
             return;
         }
 
-        if (($first = reset($map)) && !is_array($first) && !is_numeric(key($map))) {
-            parent::init($map, false);
-            return;
-        }
-
         $propertiesMap = PPUtils::objectProperties($this);
         $arrayCtr      = array();
         foreach ($map as $element) {

lib/PayPal/Core/PPXmlMessage.php

@@ -120,11 +120,6 @@ public function init(array $map = array(), $isRoot = true)
             return;
         }
 
-        if (($first = reset($map)) && !is_array($first) && !is_numeric(key($map))) {
-            parent::init($map, false);
-            return;
-        }
-
         $propertiesMap = PPUtils::objectProperties($this);
         $arrayCtr      = array();
         foreach ($map as $element) {