Merge pull request #62 from pebble-dev/add_forum_override_option

Add forum override option

Author: Willow-Systems

appstore/developer_portal_api.py

@@ -18,6 +18,7 @@
 from .s3 import upload_pbw, upload_asset, get_link_for_archive
 from .settings import config
 from .discord import audit_log
+from .discourse import get_topic_url_for_app, is_valid_topic_url, user_owns_discourse_topic, topic_url_to_id
 from . import discord, discourse
 
 parent_app = None
@@ -649,6 +650,47 @@ def new_app_icon(app_id, size):
 
     return jsonify(success=True, id=new_image_id, size=size)
 
+@devportal_api.route("/app/<app_id>/forum", methods=['GET'])
+def get_app_forum_url(app_id):
+    try:
+        app = App.query.filter(App.id == app_id).one()
+    except NoResultFound:
+        return jsonify(error="Unknown app", e="app.notfound"), 404
+
+    return jsonify(forum_url=get_topic_url_for_app(app))
+
+@devportal_api.route("/app/<app_id>/forum", methods=['POST'])
+def update_app_forum_url(app_id):
+    try:
+        req = request.json
+    except BadRequest:
+        return jsonify(error="Invalid POST body. Expected JSON", e="body.invalid"), 400
+
+    if req is None:
+        return jsonify(error="Invalid POST body. Expected JSON and 'Content-Type: application/json'", e="request.invalid"), 400
+
+    if "new_url" not in req:
+        return jsonify(error="Missing required field: new_url", e="missing.field.new_url"), 400
+
+    try:
+        app = App.query.filter(App.id == app_id).one()
+    except NoResultFound:
+        return jsonify(error="Unknown app", e="app.notfound"), 404
+
+    if not is_users_developer_id(app.developer_id):
+        return jsonify(error="You do not have permission to modify that app", e="permission.denied"), 403
+
+    if not is_valid_topic_url(req["new_url"]):
+        return jsonify(error="Invalid URL for new discourse topic", e="url.invalid"), 400
+
+    if not user_owns_discourse_topic(req["new_url"]):
+        return jsonify(error="You are not the creator of the provided discourse topic", e="url.permissions.missing"), 400
+
+    app.discourse_topic_id = topic_url_to_id(req["new_url"])
+    db.session.commit()
+
+    return jsonify(success=True, new_url=app.discourse_topic_id)
+
 
 
 @devportal_api.route('/wizard/rename/<developer_id>', methods=['POST'])

appstore/discourse.py

@@ -3,7 +3,9 @@
 from .settings import config
 from .models import App, db
 from .discord import random_party_emoji
-from .utils import get_app_description, generate_image_url
+from .utils import get_app_description, generate_image_url, demand_authed_request
+import requests
+import json
 
 PLATFORM_EMOJI = {
     'aplite': ':pebble-orange:',
@@ -16,6 +18,7 @@
 
 if config['DISCOURSE_API_KEY'] is None:
     _client = None
+    print("== Discourse Integration not configured.")
 else:
     _client = DiscourseClient(host=f"https://{config['DISCOURSE_HOST']}", api_username=config['DISCOURSE_USER'], api_key=config['DISCOURSE_API_KEY'])
 
@@ -120,6 +123,45 @@ def announce_new_app(app, is_generated, is_new=True):
 """)
 
 def get_topic_url_for_app(app):
-    if not _client or not app.discourse_topic_id or app.discourse_topic_id == -1:
-        return None
-    return f"https://{config['DISCOURSE_HOST']}/t/{app.discourse_topic_id}"
+    if app.discourse_topic_id > 0:
+        return f"https://{config['DISCOURSE_HOST']}/t/{app.discourse_topic_id}"
+    else:
+        return
+
+def is_valid_topic_url(topic_url):
+    topic_url = topic_url.lower().strip()
+
+    start_string = config['DISCOURSE_HOST'].lower()
+    if not start_string.startswith("http://"):
+        start_string = "https://" + start_string
+
+    return topic_url.startswith(start_string)
+
+def topic_url_to_id(topic_url):
+    topic_url = topic_url.lower().strip()
+    if "?" in topic_url:
+        topic_url = topic_url[:topic_url.index("?")]
+    sections = topic_url.split("/")
+
+    if len(sections) == 5:
+        # Short url: https://discourse.example.com/t/12345
+        return int(sections[4])
+    else:
+        # Long url: https://discourse.example.com/t/topic-title/12345
+        # Long url with page: https://discourse.example.com/t/topic-title/12345/2
+        return int(sections[5])
+
+def fetch_owner_from_topic_url(topic_url):
+    #The py client sucks a bit so we'll just call the JSON
+    topic = requests.request("GET", topic_url + ".json").json()
+    topic_owner = topic["details"]["created_by"]["username"]
+    return topic_owner
+
+def user_owns_discourse_topic(discourse_topic_url):
+    discourse_username = fetch_owner_from_topic_url(discourse_topic_url)
+
+    auth_result = demand_authed_request('GET', f"{config['REBBLE_AUTH_URL']}/api/v1/me/pebble/appstore")
+    me = auth_result.json()
+    my_username = me["rebble_username"]
+
+    return discourse_username == my_username

appstore/settings.py

@@ -28,7 +28,7 @@
     'AWS_SECRET_KEY': os.environ.get('AWS_SECRET_KEY', None),
     'S3_ENDPOINT': os.environ.get('S3_ENDPOINT', None),
     'TEST_APP_UUID': os.environ.get('TEST_APP_UUID', None),
-    'DISCOURSE_USER': os.environ.get('DISCOURSE_USER', 'annedroid'),
+    'DISCOURSE_USER': os.environ.get('DISCOURSE_USER', 'anne_droid'),
     'DISCOURSE_API_KEY': os.environ.get('DISCOURSE_API_KEY', None),
     'DISCOURSE_HOST': os.environ.get('DISCOURSE_HOST', f'forum.{domain_root}'),
     'DISCOURSE_SHOWCASE_TOPIC_ID': int(os.environ.get('DISCOURSE_SHOWCASE_TOPIC_ID', '3')),