discourse: use 0 rather than None as an empty topic_id

Author: jwise

appstore/commands.py

@@ -138,6 +138,7 @@ def import_apps(app_type):
             },
             created_at=parse_datetime(app['created_at']),
             developer=dev,
+            discourse_topic_id=0,
             hearts=app['hearts'],
             releases=[
                 *([Release(
@@ -305,6 +306,7 @@ def import_app_from_locker(locker_app):
         title=locker_app['title'],
         type=locker_app['type'],
         website=None,
+        discourse_topic_id=0,
         visible=False,
     )
     db.session.add(app)

appstore/developer_portal_api.py

@@ -177,6 +177,7 @@ def submit_new_app():
             companions={}, # companions not supported yet
             created_at=datetime.datetime.utcnow(),
             developer=developer,
+            discourse_topic_id=0,
             hearts=0,
             releases=[],
             icon_large=upload_asset(request.files['large_icon'], request.files["large_icon"].content_type),

appstore/discourse.py

@@ -28,12 +28,12 @@ def _create_or_post_to_topic(app, is_generated, text):
         # should go in their own topic later?
         return
 
-    if app.discourse_topic_id is -1:
+    if app.discourse_topic_id == -1:
         # We have manually set that we don't want a Discourse topic at all
         # for this app.  Don't post at all.
         return
 
-    if app.discourse_topic_id is None:
+    if app.discourse_topic_id == 0:
         # This app doesn't have a topic of its own yet; create a new one,
         # and store it in the database.
 

migrations/versions/89e32c02be56_add_discourse_topic_id.py

@@ -19,6 +19,11 @@
 def upgrade():
     # ### commands auto generated by Alembic - please adjust! ###
     op.add_column('apps', sa.Column('discourse_topic_id', sa.Integer(), nullable=True))
+    op.execute("""
+        UPDATE apps
+        SET discourse_topic_id = 0
+    """)
+
     # ### end Alembic commands ###