Skip to content

bugfix: analyst should ignore seen articles from previous days #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 7, 2025
Merged

bugfix: analyst should ignore seen articles from previous days #44

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions analyst.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,14 @@ func generateAnalysis(fp *gofeed.Parser, writer Writer) {
continue
}
for _, item := range parsedFeed.Items {
seen, seen_today, summary := isSeenArticle(item, "#analyst")
if seen {
continue
}
articleTitles = append(articleTitles, item.Title+": "+item.Description) // add also description for better context
if !seen_today {
addToSeenTable(item.Link+"#analyst", summary)
}
}
}

Expand Down
6 changes: 3 additions & 3 deletions feeds_writer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ func generateFeedItems(w Writer, feed *gofeed.Feed, rss RSS) string {
var items string

for _, item := range feed.Items {
seen, seen_today, summary := isSeenArticle(item)
seen, seen_today, summary := isSeenArticle(item, "")
if seen {
continue
}
Expand Down Expand Up @@ -266,11 +266,11 @@ func getInstapaperLink(link string) string {
return "[<img height=\"16\" src=\"https://staticinstapaper.s3.dualstack.us-west-2.amazonaws.com/img/favicon.png\">](https://www.instapaper.com/hello2?url=" + link + ")"
}

func isSeenArticle(item *gofeed.Item) (seen bool, today bool, summaryText string) {
func isSeenArticle(item *gofeed.Item, postfix string) (seen bool, today bool, summaryText string) {
var url string
var date string
var summary sql.NullString
err := db.QueryRow("SELECT url, date, summary FROM seen WHERE url=?", item.Link).Scan(&url, &date, &summary)
err := db.QueryRow("SELECT url, date, summary FROM seen WHERE url=?", item.Link+postfix).Scan(&url, &date, &summary)
if err != nil && err != sql.ErrNoRows {
fmt.Println(err)
return false, false, ""
Expand Down
Loading