Player: fixed suspicious ground state check

dktapps · dktapps · commit 806d88ec20f3 · 2025-10-19T00:34:14.000+01:00
fixes #3552 and #3553 for non-spectator-gamemode situations this would've caused problems if setHasBlockCollision(false) was used in other game modes
diff --git a/src/player/Player.php b/src/player/Player.php
@@ -1304,7 +1304,7 @@ public function getXpDropAmount() : int{
 	}
 
 	protected function checkGroundState(float $wantedX, float $wantedY, float $wantedZ, float $dx, float $dy, float $dz) : void{
-		if($this->gamemode === GameMode::SPECTATOR){
+		if(!$this->blockCollision){
 			$this->onGround = false;
 		}else{
 			$bb = clone $this->boundingBox;

Original file line number	Diff line number	Diff line change
`@@ -1304,7 +1304,7 @@ public function getXpDropAmount() : int{`
`1304`	`1304`	`}`
`1305`	`1305`
`1306`	`1306`	`protected function checkGroundState(float $wantedX, float $wantedY, float $wantedZ, float $dx, float $dy, float $dz) : void{`
`1307`		`- if($this->gamemode === GameMode::SPECTATOR){`
	`1307`	`+ if(!$this->blockCollision){`
`1308`	`1308`	`$this->onGround = false;`
`1309`	`1309`	`}else{`
`1310`	`1310`	`$bb = clone $this->boundingBox;`