Snapshot not change due to subscribe after delete

[pilaoda]

Bug Description

import { proxy, snapshot, subscribe } from "valtio";

const obj = { s: { a: 0 } } as any;
const state = proxy(obj);
const snapshot1 = snapshot(state);
delete state.s.a;
subscribe(state, () => { }); // remove this line, snapshot1 and snapshot2 will become unequal.
const snapshot2 = snapshot(state);
console.log(snapshot1 === snapshot2); // true, why?

Is this behavior by design? Why skip version update if listeners is not empty?

valtio/src/vanilla.ts

Line 203 in 7537417

if (checkVersion !== nextCheckVersion && !listeners.size) {

I can't trigger a re-render if a nested obj prop is deleted before the subscribe of useSyncExternalStore called.

valtio/src/react.ts

Line 136 in 7537417

const unsub = subscribe(proxyObject, callback, notifyInSync)

I found out it is due to the version not update if it is subscribed after delete.

Reproduction Link

https://stackblitz.com/edit/node-ycp9r3?file=index.js

[dai-shi]

No, it sounds like a bug. Nice catch.

Would you like to add a failing test and see if removing && !listeners.size fixes it, while keeping other tests pass?

[dai-shi]

Hm, maybe the bug is somewhere else.

Why skip version update if listeners is not empty?

The intention was, if there's a listener, the version should have been already updated.

[pilaoda]

i can just remove && !listeners.size，but is that all？Is it ok if the version +2 in this case?

[dai-shi]

I previously misunderstood the test code. Yeah, I think that's all.

Is it ok if the version +2 in this case?

What do you mean? If curious, try to add some tests.

[pilaoda]

I previously misunderstood the test code. Yeah, I think that's all.

Is it ok if the version +2 in this case?

What do you mean? If curious, try to add some tests.

nothing. I misunderstand the version logic. it works as expect now.

[pilaoda]

PR here: #1153