-
-
Notifications
You must be signed in to change notification settings - Fork 281
refactor(utils): changes to proxySet for new typescript impl #1175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
|
Size Change: +259 B (+1.8%) Total Size: 14.7 kB
ℹ️ View Unchanged
|
commit: |
|
I added an I reimplemented the new set methods using TS overloads so they will accept "Set-like" objects. Added |
dai-shi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this. Comments below.
dai-shi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Related Bug Reports or Discussions
Fixes #
Summary
Check List
pnpm run fixfor formatting and linting code and docs