Skip to content

Commit d71cf1c

Browse files
authored
Merge pull request #142 from sidz/enable-strict-type
Enable strict_type mode
2 parents 7fc703d + add57d7 commit d71cf1c

31 files changed

+81
-114
lines changed

src/Console/Application.php

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
<?php
22

3+
declare(strict_types=1);
4+
35
namespace Povils\PHPMND\Console;
46

57
use Symfony\Component\Console\Application as BaseApplication;
@@ -8,11 +10,6 @@
810
use Symfony\Component\Console\Input\InputInterface;
911
use Symfony\Component\Console\Output\OutputInterface;
1012

11-
/**
12-
* Class Application
13-
*
14-
* @package Povils\PHPMND\Console
15-
*/
1613
class Application extends BaseApplication
1714
{
1815
const VERSION = '2.4.0';

src/Console/Command.php

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
<?php
22

3+
declare(strict_types=1);
4+
35
namespace Povils\PHPMND\Console;
46

57
use Povils\PHPMND\Detector;
@@ -17,11 +19,6 @@
1719
use Symfony\Component\Console\Input\InputOption;
1820
use Symfony\Component\Console\Output\OutputInterface;
1921

20-
/**
21-
* Class Command
22-
*
23-
* @package Povils\PHPMND\Console
24-
*/
2522
class Command extends BaseCommand
2623
{
2724
const EXIT_CODE_SUCCESS = 0;
@@ -232,7 +229,7 @@ private function getCSVOption(InputInterface $input, string $option): array
232229
$result = $input->getOption($option);
233230
if (false === is_array($result)) {
234231
return array_filter(
235-
explode(',', $result),
232+
explode(',', (string) $result),
236233
function ($value) {
237234
return false === empty($value);
238235
}
@@ -270,7 +267,7 @@ private function getFileOption($filename)
270267
{
271268
$filename = $this->convertFileDescriptorLink($filename);
272269

273-
if (file_exists($filename)) {
270+
if (is_string($filename) && file_exists($filename)) {
274271
return array_map('trim', file($filename));
275272
}
276273

@@ -279,7 +276,7 @@ private function getFileOption($filename)
279276

280277
private function convertFileDescriptorLink($path)
281278
{
282-
if (strpos($path, '/dev/fd') === 0) {
279+
if (is_string($path) && strpos($path, '/dev/fd') === 0) {
283280
return str_replace('/dev/fd', 'php://fd', $path);
284281
}
285282

src/Console/Option.php

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,11 @@
11
<?php
22

3+
declare(strict_types=1);
4+
35
namespace Povils\PHPMND\Console;
46

57
use Povils\PHPMND\Extension\Extension;
68

7-
/**
8-
* @package Povils\PHPMND\Console
9-
*/
109
class Option
1110
{
1211
/**

src/Detector.php

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
<?php
22

3+
declare(strict_types=1);
4+
35
namespace Povils\PHPMND;
46

57
use PhpParser\Lexer;
@@ -12,11 +14,6 @@
1214
use Symfony\Component\Finder\SplFileInfo;
1315
use const PHP_VERSION;
1416

15-
/**
16-
* Class Detector
17-
*
18-
* @package Povils\PHPMND
19-
*/
2017
class Detector
2118
{
2219
/**

src/Extension/ArgumentExtension.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
<?php
22

3+
declare(strict_types=1);
4+
35
namespace Povils\PHPMND\Extension;
46

57
use PhpParser\Node;

src/Extension/ArrayExtension.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
<?php
22

3+
declare(strict_types=1);
4+
35
namespace Povils\PHPMND\Extension;
46

57
use PhpParser\Node;
@@ -27,7 +29,7 @@ public function extend(Node $node): bool
2729
private function ignoreArray(ArrayItem $node): bool
2830
{
2931
$arrayKey = $node->key;
30-
32+
3133
return $this->option->allowArrayMapping() &&
3234
$arrayKey instanceof String_ &&
3335
false === ($this->option->includeNumericStrings() && is_numeric($arrayKey->value));

src/Extension/AssignExtension.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
<?php
22

3+
declare(strict_types=1);
4+
35
namespace Povils\PHPMND\Extension;
46

57
use PhpParser\Node;

src/Extension/ConditionExtension.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
<?php
22

3+
declare(strict_types=1);
4+
35
namespace Povils\PHPMND\Extension;
46

57
use PhpParser\Node;

src/Extension/DefaultParameterExtension.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
<?php
22

3+
declare(strict_types=1);
4+
35
namespace Povils\PHPMND\Extension;
46

57
use PhpParser\Node;

src/Extension/Extension.php

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,12 @@
11
<?php
22

3+
declare(strict_types=1);
4+
35
namespace Povils\PHPMND\Extension;
46

57
use PhpParser\Node;
68
use Povils\PHPMND\Console\Option;
79

8-
/**
9-
* @package Povils\PHPMND\Extension
10-
*/
1110
abstract class Extension
1211
{
1312
/**

0 commit comments

Comments
 (0)