Merge pull request #619 from Spirit-act/broken-conditionals

fix: use explicit bool instead of implicit truthy

Author: SuperQ

roles/_common/tasks/configure.yml

@@ -33,7 +33,7 @@
   become: true
   notify:
     - "{{ ansible_parent_role_names | first }} : Restart {{ _common_service_name }}"
-  when: (_common_config_dir)
+  when: (_common_config_dir | length > 0)
   tags:
     - "{{ ansible_parent_role_names | first | regex_replace(ansible_collection_name ~ '.', '') }}"
     - configure

roles/_common/tasks/install.yml

@@ -81,7 +81,7 @@
     - name: "Verify checksum of {{ __common_binary_basename }}"
       run_once: true
       check_mode: false
-      when: (_common_checksums_url)
+      when: (_common_checksums_url | length > 0)
       block:
         - name: "Fetch checksum list for {{ __common_binary_basename }}"
           ansible.builtin.uri:

roles/_common/tasks/preflight.yml

@@ -57,7 +57,7 @@
   ansible.builtin.package:
     name: "{{ _common_dependencies }}"
     state: present
-  when: (_common_dependencies)
+  when: (_common_dependencies != None)
   tags:
     - "{{ ansible_parent_role_names | first | regex_replace(ansible_collection_name ~ '.', '') }}"
     - configure
@@ -84,4 +84,4 @@
           reject('match', '.+:\\d+$') |
           list |
           length == 0
-  when: (_common_web_listen_address)
+  when: (_common_web_listen_address | length > 0)