WIP

Author: pascalbaljet

.github/workflows/run-tests.yml

@@ -10,7 +10,7 @@ jobs:
     strategy:
       fail-fast: true
       matrix:
-        os: [ubuntu-20.04, windows-2019]
+        os: [ubuntu-20.04]
         php: [8.1, 8.0]
         laravel: [9.*]
         ffmpeg: [5.0, 4.4]
@@ -35,6 +35,7 @@ jobs:
       - name: Install FFmpeg
         uses: Iamshankhadeep/[email protected]
         with:
+          token: ${{ secrets.CI_GITHUB_TOKEN }}
           version: ${{ matrix.ffmpeg }}
         id: setup-ffmpeg
 

README.md

@@ -29,7 +29,6 @@ It's the *magic* of Inertia.js with the *simplicity* of Blade. [Splade](https://
 * Built-in support for generating *VTT Preview Thumbnail* files.
 * Requires PHP 8.0 and 8.1.
 * Tested with FFmpeg 4.4 and 5.0.
-* Lots of integration tests, GitHub Actions with both Ubuntu and Windows.
 
 ## Installation
 

src/Exporters/VTTPreviewThumbnailsGenerator.php

@@ -63,7 +63,7 @@ private function getTimestamp(int $thumbKey): string
             '%02d:%02d:%02d.000',
             ($thumbKey * $this->tileFilter->interval) / 3600,
             ($thumbKey * $this->tileFilter->interval) / 60 % 60,
-            ($thumbKey * $this->tileFilter->interval) % 60
+            ($thumbKey * $this->tileFilter->interval)      % 60
         );
     }
 
@@ -83,7 +83,7 @@ public function getContents(): string
         return Collection::range(1, $totalFiles * $thumbsPerTile)
             ->map(function ($thumb) use ($thumbsPerTile) {
                 $start = $this->getTimestamp($thumb - 1, $this->tileFilter->interval);
-                $end = $this->getTimestamp($thumb, $this->tileFilter->interval);
+                $end   = $this->getTimestamp($thumb, $this->tileFilter->interval);
 
                 $fileKey = ceil($thumb / $thumbsPerTile);
 
@@ -93,7 +93,7 @@ public function getContents(): string
                 );
 
                 $positionOnTile = ($thumb - 1) % $thumbsPerTile;
-                $position = $this->getPositionOnTile($positionOnTile);
+                $position       = $this->getPositionOnTile($positionOnTile);
 
                 return implode(PHP_EOL, [
                     "{$start} --> {$end}",

tests/VTTPreviewThumbnailsGeneratorTest.php

@@ -10,17 +10,6 @@ class VTTPreviewThumbnailsGeneratorTest extends TestCase
 {
     use MatchesSnapshots;
 
-    private function updateWindowsNewLines($content)
-    {
-        if (!windows_os()) {
-            return $content;
-        }
-
-        $content = str_replace("\r\n", "\n", $content);
-        $content = str_replace("\n", "\r\n", $content);
-
-        return $content;
-    }
 
     /** @test */
     public function it_can_generate_a_vtt_file()
@@ -34,7 +23,7 @@ public function it_can_generate_a_vtt_file()
 
         $generator = new VTTPreviewThumbnailsGenerator($tile, 250, fn () => "sprite_%d.jpg");
 
-        $this->assertMatchesTextSnapshot($this->updateWindowsNewLines($generator->getContents()));
+        $this->assertMatchesTextSnapshot($generator->getContents());
     }
 
     /** @test */
@@ -51,7 +40,7 @@ public function it_can_generate_a_vtt_file_with_a_non_sqaure_grid()
             return "sprite_{$i}.jpg";
         });
 
-        $this->assertMatchesTextSnapshot($this->updateWindowsNewLines($generator->getContents()));
+        $this->assertMatchesTextSnapshot($generator->getContents());
     }
 
     /** @test */
@@ -70,6 +59,6 @@ public function it_can_generate_a_vtt_file_and_keep_the_margin_and_padding_in_ac
             return "sprite_{$i}.jpg";
         });
 
-        $this->assertMatchesTextSnapshot($this->updateWindowsNewLines($generator->getContents()));
+        $this->assertMatchesTextSnapshot($generator->getContents());
     }
 }