Fix example app #16
Open
Fix example app #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix android manifest by adding mandatory attribute android:exported. Signed-off-by: Tim Froidcoeur <[email protected]>
handle nullable bool defaults Signed-off-by: Tim Froidcoeur <[email protected]>
make the flutter calls await the closing of the system dialog. this requires removing the FLAG_ACTIVITY_NEW_TASK flag from the ACTION_REQUEST_IGNORE_BATTERY_OPTIMIZATIONS activity. Signed-off-by: Tim Froidcoeur <[email protected]>
to make sure the done callback is always called, make the dialog non-cancellable. There seem not to be (obvious) cancel/dismiss callbacks in java on the com.afollestad.materialdialogs.MaterialDialog class, so easiest is to just disable the possibility to cancel/dismiss the dialog by tapping outside of it. Signed-off-by: Tim Froidcoeur <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
small fixes for the example app