Bugfix for flow_map_start.
#121
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To my best understanding, in 4e5edc9, the `flow_map_*` and `flow_seq_*` class variables were added to allow different formatting for flow mappings and flow sequences. However, it seems that these are currently not functional due to an assert. This commit makes a small change to allow, in particular, the `flow_map_start` variable to be set and adds a test to help prevent a future regression.
for more information, see https://pre-commit.ci
smurfix
approved these changes
Oct 1, 2025
Collaborator
smurfix
left a comment
smurfix
left a comment
There was a problem hiding this comment.
I don't have time for an in-depth review right now, but this looks sufficiently sane to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To my best understanding, in 4e5edc9, the
flow_map_*andflow_seq_*class variables were added to allow different formatting for flow mappings and flow sequences. However, it seems that these are currently not functional due to an assert.This commit makes a small change to allow, in particular, the
flow_map_startvariable to be set and adds a test to help prevent a future regression.