Skip to content

Feature/location #1254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 14, 2025
Merged

Feature/location #1254

merged 2 commits into from
Jul 14, 2025

Conversation

@neolooong
Copy link
Contributor

@neolooong neolooong commented Jul 9, 2025

Types of changes

  • New feature

Description

  1. 更改地點
  2. 議程 API 區分 custom_event 與 break_event，並回傳連結路徑，讓前端的時間表可以跳轉到其他頁面 (自訂活動)。

@neolooong
feat: update the selection of location
e23bce9 
add new locations and removed locations that will not be used this year.
@codecov
Copy link

codecov bot commented Jul 9, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 53.84615% with 6 lines in your changes missing coverage. Please review.

Project coverage is 74.59%. Comparing base (fa6be49) to head (f9e61b3).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
src/events/api/views.py 40.00% 6 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1254      +/-   ##
==========================================
- Coverage   74.67%   74.59%   -0.09%     
==========================================
  Files          84       84              
  Lines        3171     3184      +13     
==========================================
+ Hits         2368     2375       +7     
- Misses        803      809       +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@neolooong neolooong requested a review from Ritabear July 9, 2025 13:33
@Ritabear Ritabear requested a review from mattwang44 July 10, 2025 01:35
Ritabear
Ritabear approved these changes Jul 10, 2025
View reviewed changes
Copy link
Collaborator

@Ritabear Ritabear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mattwang44
mattwang44 reviewed Jul 10, 2025
View reviewed changes
src/events/api/views.py Outdated
Comment on lines 254 to 256
def custom_event(self) -> bool:
if isinstance(self.obj, CustomEvent):
return not self.obj.break_event and self.obj.link_path != ''
Copy link
Member

@mattwang44 mattwang44 Jul 10, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto: function 做的事情和 custom_event 這個命名不符
"Custom Event" 是一種 event type，而 "Break Event" 是它的一個 break_event attribute 都為 true 的子集，但這個 property 卻只有在 self.obj 為「非 break event 的 custom event」才是 true

src/events/api/views.py
Copy link
Member

@mattwang44 mattwang44 Jul 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test cases?

Copy link
Collaborator

@Ritabear Ritabear Jul 10, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

這東西當初沒有溝通好，所以又是一張這兩天必須完成的票
議程組還要上去打議程資訊
所以測試我請他之後補

Copy link
Contributor Author

@neolooong neolooong Jul 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

這個 EventWrapper 本來就還沒有測試
https://app.codecov.io/gh/pycontw/pycon.tw/pull/1254/blob/src/events/api/views.py#L142

src/events/models.py
Comment on lines +119 to +121
SPT_OS = '81-spt-os' # sprint / open space
TUTORIAL = '82-tutorial' # tutorial
YI_PS = '83-yi-ps' # young inspire / poster session
Copy link
Member

@mattwang44 mattwang44 Jul 10, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

過去都是用 location 名稱 (會議室編號) 來作為選項，為何這裡會用活動名稱作為選項？
（送到前端傳達的意思變成「tutorial（活動）在 tutorial（地點）舉辦」，這樣是預期的嗎？）

Copy link
Collaborator

@Ritabear Ritabear Jul 10, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是 今天的scedule變動比較大，然後這些都要單獨一個一軌，名稱就是location，然後給議程組設定活動
前端部分會像coscup

Copy link
Member

@mattwang44 mattwang44 Jul 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

前端對於活動地點的資訊會如何呈現呢？有設計稿或者任何文字說明嗎？
我現在比較難想像後端這樣修改之後前端要怎麼使用這些資訊

Copy link
Collaborator

@Ritabear Ritabear Jul 11, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image 類似這種感覺吧 對方當初給我說明是線上口頭跟我們說明 時間也是不是pycon 以往切死的時間段

Copy link
Member

@mattwang44 mattwang44 Jul 11, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

送到前端傳達的意思變成「tutorial（活動）在 tutorial（地點）舉辦」，這樣是預期的嗎？

我覺得這樣就是會產生這個問題XD
不過這不是程式問題, not a PR blocker，要跟 stakeholder 確認這是預期行為及可能發生的問題

時間也是不是pycon 以往切死的時間段

有更多說明嗎（什麼意思、預期怎麼實作）？
「切死的時間段」指的是「 schedule 頁面上 slot 長度大致與活動時長成正比」還是「schedule 頁面上橫軸位置大致代表時間點」？我覺得這兩件事任一被改掉都只會對 UX 有負面影響

Copy link
Collaborator

@Ritabear Ritabear Jul 11, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

會把一個活動 EX: tutorial 標記為是在「tutorial」這個地點舉辦。是當初PM跟我們說的
他們到時候會在教室外面貼這是tutorial地點

目前每個活動時長不一、可以有彈性，slot 不再強制對齊 (schedule 頁面上 slot 長度大致與活動時長成正比) 會像是google calender 一樣，時間多長就佔多長的bolck 跟位置

這兩個都是今年新需求
不知道有沒有回答到><

Copy link
Member

@mattwang44 mattwang44 Jul 11, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

但是 google calendar 是完全的 slot 長度與活動時長成正比，過去的 schedule 頁面也是時間比較長就會有顯示比較長的 slot （只是 DB 的 "Time" table 就要塞好每個時間點），所以我看不出你描述的差異是什麼？

Copy link
Collaborator

@Ritabear Ritabear Jul 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我們有discord 回覆><

@Ritabear Ritabear merged commit 43e50e6 into master Jul 14, 2025
1 of 3 checks passed
@Ritabear Ritabear deleted the feature/location branch July 14, 2025 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattwang44 mattwang44 mattwang44 left review comments

@Ritabear Ritabear Ritabear approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@neolooong @mattwang44 @Ritabear