-
-
Notifications
You must be signed in to change notification settings - Fork 59
Opengraph only 244 #265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ArnavBallinCode
wants to merge
13
commits into
pyladies:main
Choose a base branch
from
ArnavBallinCode:opengraph-only-244
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Opengraph only 244 #265
ArnavBallinCode
wants to merge
13
commits into
pyladies:main
from
ArnavBallinCode:opengraph-only-244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pyladiescon-portal-docs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
- Add base OpenGraph tags to base.html template - og:title, og:description, og:type, og:url, og:image - og:image:alt, og:site_name, og:locale - Add Twitter Card meta tags to base.html - twitter:card, twitter:title, twitter:description - twitter:image, twitter:image:alt - Implement custom OpenGraph blocks for public pages: - Homepage (index.html) - Stats page (stats.html) - Volunteer page (volunteer/index.html) - Sponsorship page (sponsorship/sponsorshipprofile_list.html) - Login page (account/login.html) - Signup page (account/signup.html) All pages now have proper social media preview tags that can be tested with browser extensions or social media preview tools.
2095fbf to
43085c7
Compare
- Fixed Django template syntax errors in base.html (multi-line conditionals, URL tags, language selection) - Fixed blocktranslate syntax error in account/login.html - All 319 tests now passing with 100% coverage - OpenGraph and Twitter Card meta tags implemented across all public pages - Templates functional and ready for production pyladies#244
Contributor
Author
|
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fixes #244
added OpenGraph and Twitter Card meta tags to public pages so that shared links display rich, visually appealing previews on social media platforms.
It also fixes several Django template syntax issues introduced during previous formatting (via
djlint), including ablocktranslateclosing tag bug that caused rendering errors.These changes preserve existing site behavior while improving SEO and shareability, without modifying any backend models or database schema.
Changes
1. Implemented Site-wide Meta Tag Blocks
base.html:og_title,og_description,og_type,og_url,og_image,og_image_alttwitter_*blocks for Twitter-specific overrides2. Added Page-level Overrides
Enhanced preview accuracy for key public and authentication pages:
index.htmlstats.htmllogin.htmlsignup.html3. Fixed Template Syntax Errors
Manual fixes to prevent
djlintfrom breaking Django tags:login.html— correctedblocktranslateusage and element nestingbase.html— fixed multi-line tag formatting,urltag syntax, and language selector markupsponsorshipprofile_list.html— minor structural fix