Switch SVN Windows CI installation to winget / Slik.Subversion

[notatallshaw]

Fixes #13644

Let's see if this work.

Helpful information was sourced from: https://michielvoo.net/2023/01/12/installing-svn-on-windows.html

[notatallshaw]

Okay, well this got SVN working on Windows, but it appears that "winget" is less of a package manager and more of an arbitrary URL redirect.

The TortoiseSVN manifest points to sourceforge which rejects GitHub downloads.

The Slik.Subversion manifest points to this project: https://github.com/AmpScm/SharpSvn/releases. The projects main purpose seems to be rebuilding Slik SVN for nuget packaging. It was added to winget in this PR and as best as I can tell looks legitimate: microsoft/winget-pkgs#59580

[pfmoore]

There's also scoop, which installs sliksvn from https://sliksvn.com/pub/Slik-Subversion-1.14.5-x64.zip. That looks like a far more legitimate version of sliksvn. It doesn't look like scoop is installed on the Windows runners by default, though.

I guess if things are working for now let's just leave it at that. But if it starts failing again, I think we should drop the svn-related tests from at least the Windows CI¹, and seriously consider skipping the tests altogether - svn support can be left as community-maintained if we don't want to outright remove it.

Footnotes

1. In my experience, getting a decent Windows build of subversion has been pretty difficult for years at this point. ↩

[notatallshaw]

There were a few URLs to vendor specific sites I could of used, but I chose the current solution because it technically doesn't rely on a specific version (someone could re-point that winget manifest to a newer build at some point), and because vendor sites might go down or decide to block GitHub, whereas the underlying URL here is a GitHub release artifact.

My opinion on VCS tests is if they ever break in a way no maintainer is willing to fix, let's just turn them off, but until then I would rather keep them on.

[ichard26]

I'm not the hugest fan of using this somewhat nebulous source for Subversion, but if it's the best we got without doing even more work (installing scoop is meh) then I'll live with it. I'm favour of removing our tests (without removing the svn code) if they continue to break.

Feel free to merge to unblock CI and fix the main branch.

[ichard26]

Hmm, actually I just merged #13407 and CI passed for it. Also the main branch is green right now. I guess the 403 error was indeed transient..? https://github.com/pypa/pip/actions/runs/19242636390

[notatallshaw]

We have previously had transient issues with installing SVN from chocolatey, I was going to add a retry loop on it at some point. But going down for multiple hours is t really sustainable, so I'm still +1 on a separate source.