Skip to content

Commit a069b5d

Browse files
committed
fix: use packaging.version.Version for semver comparison in setup.py
1 parent 1c325b2 commit a069b5d

4 files changed

Lines changed: 6 additions & 8 deletions

File tree

extension_cpp/requirements.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,3 @@
11
torch
22
numpy
3+
packaging

extension_cpp/setup.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
import glob
99

1010
from setuptools import find_packages, setup
11+
from packaging.version import Version
1112

1213
from torch.utils.cpp_extension import (
1314
CppExtension,
@@ -18,10 +19,7 @@
1819

1920
library_name = "extension_cpp"
2021

21-
if torch.__version__ >= "2.6.0":
22-
py_limited_api = True
23-
else:
24-
py_limited_api = False
22+
py_limited_api = Version(torch.__version__) >= Version("2.6.0")
2523

2624

2725
def get_extensions():
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,3 @@
11
torch
22
numpy
3+
packaging

extension_cpp_stable/setup.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
import glob
99

1010
from setuptools import find_packages, setup
11+
from packaging.version import Version
1112

1213
from torch.utils.cpp_extension import (
1314
CppExtension,
@@ -19,10 +20,7 @@
1920
library_name = "extension_cpp_stable"
2021

2122

22-
if torch.__version__ >= "2.6.0":
23-
py_limited_api = True
24-
else:
25-
py_limited_api = False
23+
py_limited_api = Version(torch.__version__) >= Version("2.6.0")
2624

2725

2826
def get_extensions():

0 commit comments

Comments
 (0)