Making lint, style changes with some migration fixes

Author: Siddharthgolecha

docs/lowercase_filter.py

@@ -10,7 +10,7 @@
 # copyright notice, and modified files need to carry a notice indicating
 # that they have been altered from the originals.
 
-""" Implements a Lower Case Filter for Sphinx spelling """
+"""Implements a Lower Case Filter for Sphinx spelling"""
 
 from enchant import tokenize
 

qiskit_machine_learning/algorithm_job.py

@@ -29,17 +29,7 @@ def submit(self) -> None:
         """
         Submit the job for execution.
 
-        For V1 primitives, Qiskit ``PrimitiveJob`` subclassed JobV1 and defined ``submit()``.
-        ``PrimitiveJob`` was updated for V2 primitives, no longer subclasses ``JobV1``, and
-        now has a private ``_submit()`` method, with ``submit()`` being deprecated as of
-        Qiskit version 0.46. This maintains the ``submit()`` for ``AlgorithmJob`` here as
-        it's called in many places for such a job. An alternative could be to make
-        0.46 the required minimum version and alter all algorithm's call sites to use
-        ``_submit()`` and make this an empty class again as it once was. For now this
-        way maintains compatibility with the current min version of 0.44.
+        Since the library has been migrated to Qiskit v2.1, it is no longer necessary to
+        keep the :meth:``JobV1.submit()`` for the exception handling.
         """
-        # TODO: Considering changing this in the future - see above docstring.
-        try:
-            super()._submit()
-        except AttributeError:
-            super().submit()  # pylint: disable=no-member
+        super()._submit()

qiskit_machine_learning/algorithms/classifiers/__init__.py

@@ -10,11 +10,11 @@
 # copyright notice, and modified files need to carry a notice indicating
 # that they have been altered from the originals.
 
-""" Classifiers Package """
+"""Classifiers Package"""
 
 from .neural_network_classifier import NeuralNetworkClassifier
-from .qsvc import QSVC
 from .pegasos_qsvc import PegasosQSVC
+from .qsvc import QSVC
 from .vqc import VQC
 
 __all__ = ["NeuralNetworkClassifier", "QSVC", "PegasosQSVC", "VQC"]

qiskit_machine_learning/algorithms/classifiers/vqc.py

@@ -12,21 +12,21 @@
 """An implementation of variational quantum classifier."""
 
 from __future__ import annotations
+
 from typing import Callable
 
 import numpy as np
-
 from qiskit import QuantumCircuit
-from qiskit.primitives import BaseSamplerV2 # change: BaseSampler is migrated to BaseSamplerV2
+from qiskit.primitives import BaseSamplerV2
 from qiskit.transpiler.passmanager import BasePassManager
 
 from ...neural_networks import SamplerQNN
-from ...optimizers import Optimizer, OptimizerResult, Minimizer
+from ...optimizers import Minimizer, Optimizer, OptimizerResult
 from ...utils import derive_num_qubits_feature_map_ansatz
 from ...utils.loss_functions import Loss
-
 from .neural_network_classifier import NeuralNetworkClassifier
 
+
 class VQC(NeuralNetworkClassifier):
     r"""A convenient Variational Quantum Classifier implementation.
 
@@ -57,7 +57,7 @@ def __init__(
         initial_point: np.ndarray | None = None,
         callback: Callable[[np.ndarray, float], None] | None = None,
         *,
-        sampler: BaseSamplerV2 | None = None, # change: BaseSampler is migrated to BaseSamplerV2
+        sampler: BaseSamplerV2 | None = None,  # change: BaseSampler is migrated to BaseSamplerV2
         interpret: Callable[[int], int | tuple[int, ...]] | None = None,
         output_shape: int | None = None,
         pass_manager: BasePassManager | None = None,
@@ -107,7 +107,7 @@ def __init__(
         """
 
         num_qubits, feature_map, ansatz = derive_num_qubits_feature_map_ansatz(
-            num_qubits, feature_map, ansatz, use_methods=True
+            num_qubits, feature_map, ansatz
         )
 
         if output_shape is None:
@@ -197,4 +197,4 @@ def _get_interpret(self, num_classes: int):
         def parity(x: int, num_classes: int = num_classes) -> int:
             return x % num_classes
 
-        return parity
+        return parity

qiskit_machine_learning/algorithms/inference/__init__.py

@@ -10,7 +10,7 @@
 # copyright notice, and modified files need to carry a notice indicating
 # that they have been altered from the originals.
 
-""" Inference Package """
+"""Inference Package"""
 
 
 from .qbayesian import QBayesian

qiskit_machine_learning/algorithms/inference/qbayesian.py

@@ -14,17 +14,19 @@
 from __future__ import annotations
 
 import copy
-from typing import Tuple, Dict, Set, List
+from typing import Dict, List, Set, Tuple
 
-from qiskit import QuantumCircuit, ClassicalRegister
-from qiskit.quantum_info import Statevector
+from qiskit import ClassicalRegister, QuantumCircuit
 from qiskit.circuit import Qubit
 from qiskit.circuit.library import grover_operator
-from qiskit.primitives import BaseSamplerV2, StatevectorSampler # change: BaseSampler and Sampler are replaced by BaseSamplerV2 and StatevectorSampler
-from qiskit.transpiler.passmanager import BasePassManager
+from qiskit.primitives import (
+    BaseSamplerV2,
+    StatevectorSampler,
+)
+from qiskit.quantum_info import Statevector
 from qiskit.result import QuasiDistribution
+from qiskit.transpiler.passmanager import BasePassManager
 
-from ...utils.deprecation import issue_deprecation_msg
 
 class QBayesian:
     r"""
@@ -66,7 +68,7 @@ def __init__(
         *,
         limit: int = 10,
         threshold: float = 0.9,
-        sampler: BaseSamplerV2 | None = None, # change: BaseSampler is replaced by BaseSamplerV2
+        sampler: BaseSamplerV2 | None = None,
         pass_manager: BasePassManager | None = None,
     ):
         """
@@ -95,15 +97,7 @@ def __init__(
         self._limit = limit
         self._threshold = threshold
         if sampler is None:
-            sampler = StatevectorSampler() # change: Sampler is replaced by StatevectorSampler
-
-        if isinstance(sampler, BaseSamplerV2): # change: BaseSamplerV1 is replaced by BaseSamplerV2
-            issue_deprecation_msg(
-                msg="V1 Primitives are deprecated",
-                version="0.8.0",
-                remedy="Use V2 primitives for continued compatibility and support.",
-                period="4 months",
-            )
+            sampler = StatevectorSampler()
 
         self._sampler = sampler
 
@@ -166,34 +160,22 @@ def _run_circuit(self, circuit: QuantumCircuit) -> Dict[str, float]:
         """Run the quantum circuit with the sampler."""
         counts = {}
 
-        if isinstance(self._sampler, BaseSamplerV2): # change: BaseSampler is replaced by BaseSamplerV2
-            # Sample from circuit
-            job = self._sampler.run(circuit)
-            result = job.result()
+        # Sample from circuit
+        if self._pass_manager is not None:
+            circuit = self._pass_manager.run(circuit)
+        job = self._sampler.run([circuit])
+        result = job.result()
 
-            # Get the counts of quantum state results
-            counts = result.quasi_dists[0].nearest_probability_distribution().binary_probabilities()
+        bit_array = list(result[0].data.values())[0]
+        bitstring_counts = bit_array.get_counts()
 
-        elif isinstance(self._sampler, BaseSamplerV2): # change: BaseSamplerV2 is replaced by BaseSamplerV2
-            # Sample from circuit
-            if self._pass_manager is not None:
-                circuit = self._pass_manager.run(circuit)
-            job = self._sampler.run([circuit])
-            result = job.result()
-
-            bit_array = list(result[0].data.values())[0]
-            bitstring_counts = bit_array.get_counts()
-
-            # Normalize the counts to probabilities
-            total_shots = sum(bitstring_counts.values())
-            probabilities = {k: v / total_shots for k, v in bitstring_counts.items()}
-            # Convert to quasi-probabilities
-            quasi_dist = QuasiDistribution(probabilities)
-            binary_prob = quasi_dist.nearest_probability_distribution().binary_probabilities()
-            counts = {k: v for k, v in binary_prob.items() if int(k) < 2**self.num_virtual_qubits}
-
-            # counts = QuasiDistribution(probabilities)
-            # counts = {k: v for k, v in counts.items()}
+        # Normalize the counts to probabilities
+        total_shots = sum(bitstring_counts.values())
+        probabilities = {k: v / total_shots for k, v in bitstring_counts.items()}
+        # Convert to quasi-probabilities
+        quasi_dist = QuasiDistribution(probabilities)
+        binary_prob = quasi_dist.nearest_probability_distribution().binary_probabilities()
+        counts = {k: v for k, v in binary_prob.items() if int(k) < 2**self.num_virtual_qubits}
 
         return counts
 
@@ -411,12 +393,12 @@ def limit(self, limit: int):
         self._limit = limit
 
     @property
-    def sampler(self) -> BaseSamplerV2: # change: BaseSampler is replaced by BaseSamplerV2
+    def sampler(self) -> BaseSamplerV2:
         """Returns the sampler primitive used to compute the samples."""
         return self._sampler
 
     @sampler.setter
-    def sampler(self, sampler: BaseSamplerV2): # change: BaseSampler is replaced by BaseSamplerV2
+    def sampler(self, sampler: BaseSamplerV2):
         """Set the sampler primitive used to compute the samples."""
         self._sampler = sampler
 
@@ -428,4 +410,4 @@ def threshold(self) -> float:
     @threshold.setter
     def threshold(self, threshold: float):
         """Set the threshold to accept the evidence."""
-        self._threshold = threshold
+        self._threshold = threshold

qiskit_machine_learning/algorithms/regressors/__init__.py

@@ -10,10 +10,10 @@
 # copyright notice, and modified files need to carry a notice indicating
 # that they have been altered from the originals.
 
-""" Regressors Package"""
+"""Regressors Package"""
 
-from .qsvr import QSVR
 from .neural_network_regressor import NeuralNetworkRegressor
+from .qsvr import QSVR
 from .vqr import VQR
 
 __all__ = ["QSVR", "VQR", "NeuralNetworkRegressor"]

qiskit_machine_learning/algorithms/regressors/vqr.py

@@ -16,15 +16,16 @@
 
 import numpy as np
 from qiskit import QuantumCircuit
-from qiskit.primitives import BaseEstimatorV2 # change: BaseEstimator is migrated to BaseEstimatorV2
+from qiskit.primitives import BaseEstimatorV2
 from qiskit.quantum_info.operators.base_operator import BaseOperator
 from qiskit.transpiler.passmanager import BasePassManager
 
-from .neural_network_regressor import NeuralNetworkRegressor
 from ...neural_networks import EstimatorQNN
-from ...optimizers import Optimizer, Minimizer
+from ...optimizers import Minimizer, Optimizer
 from ...utils import derive_num_qubits_feature_map_ansatz
 from ...utils.loss_functions import Loss
+from .neural_network_regressor import NeuralNetworkRegressor
+
 
 class VQR(NeuralNetworkRegressor):
     """A convenient Variational Quantum Regressor implementation."""
@@ -42,7 +43,7 @@ def __init__(
         initial_point: np.ndarray | None = None,
         callback: Callable[[np.ndarray, float], None] | None = None,
         *,
-        estimator: BaseEstimatorV2 | None = None, # change: BaseEstimator is migrated to BaseEstimatorV2
+        estimator: BaseEstimatorV2 | None = None,
         pass_manager: BasePassManager | None = None,
     ) -> None:
         r"""
@@ -93,7 +94,7 @@ def __init__(
         self._estimator = estimator
 
         num_qubits, feature_map, ansatz = derive_num_qubits_feature_map_ansatz(
-            num_qubits, feature_map, ansatz, use_methods=True
+            num_qubits, feature_map, ansatz
         )
 
         # construct circuit
@@ -144,4 +145,4 @@ def ansatz(self) -> QuantumCircuit:
     @property
     def num_qubits(self) -> int:
         """Returns the number of qubits used by ansatz and feature map."""
-        return self._num_qubits
+        return self._num_qubits

qiskit_machine_learning/circuit/library/qnn_circuit.py

@@ -12,11 +12,12 @@
 
 """The QNN circuit."""
 from __future__ import annotations
+
 from typing import List
 
-from qiskit.circuit import QuantumRegister, QuantumCircuit
-from qiskit.circuit.parametertable import ParameterView
+from qiskit.circuit import QuantumCircuit, QuantumRegister
 from qiskit.circuit.library import BlueprintCircuit
+from qiskit.circuit.parametertable import ParameterView
 
 from qiskit_machine_learning import QiskitMachineLearningError
 
@@ -119,7 +120,7 @@ def qnn_circuit(
     """
     # Check if circuit is constructed with valid configuration and set properties accordingly.
     num_qubits, feature_map, ansatz = derive_num_qubits_feature_map_ansatz(
-        num_qubits, feature_map, ansatz, use_methods=True
+        num_qubits, feature_map, ansatz
     )
     qc = QuantumCircuit(num_qubits)
     qc.compose(feature_map, inplace=True)

qiskit_machine_learning/exceptions.py

@@ -10,7 +10,7 @@
 # copyright notice, and modified files need to carry a notice indicating
 # that they have been altered from the originals.
 
-""" Machine Learning Exception """
+"""Machine Learning Exception"""
 
 from qiskit.exceptions import QiskitError