[Feature Request] Allow using either left or right modifiers to toggle `ONESHOT_TAP_TOGGLE`

[leoheitmannruiz]

Feature Request Type

• Core functionality
• Add-on hardware support (eg. audio, RGB, OLED screen, etc.)
• Alteration (enhancement/optimization) of existing feature(s)
• New behavior

Description

I'd like for it to be possible to use either the left or right modifier to toggle the "One Shot Keys" ONESHOT_TAP_TOGGLE feature.

That is, suppose I have set ONESHOT_TAP_TOGGLE to 2 and I have tapped OS_LSFT twice. OS_LSFT is now held down until I tap it once again. Sometimes I'd like to tap OS_RSFT instead of OS_LSFT to stop OS_LSFT from being held down.

For now, my "workaround" is to not have left and right modifiers, just right modifiers on both sides of my keyboard. This way, however, typing tests that try to warn you when not using opposite shift keys can't do so.

Additional information

I use QWERTY on a split keyboard with shift in both thumb clusters.

An example phrase is "TAKE A NAP", where I start off by tapping the shift key on the right half twice, as the first letter is on the left half of the keyboard. Then the last character is on the right side, so I like to end by tapping the shift key on the left half (especially as the last character is typed with the pinky and is located above the home row, so my hand moves up and away from the thumb cluster).

[leoheitmannruiz]

See for instance https://monkeytype.com/settings?highlight=oppositeShiftMode for a typing test that allows for forcing you to use opposite shift keys.

[drashna]

To be blunt, this is a very, very edge case, and I'm not sure is a scenario that is best addressed in core code.

That said, this is something that can be addressed in user code, pretty easily.
https://docs.qmk.fm/one_shot_keys#callbacks

Eg,

void oneshot_mods_changed_user(uint8_t mods) {
    if (mods & MOD_MASK_SHIFT && get_oneshot_locked_mods() & MOD_MASK_SHIFT) {
        del_oneshot_locked_mods(MOD_MASK_SHIFT);
    }
}

This is untested code, but I believe should work (or at least, only require minor tweaks to get working).