Fix pytest commandline flags being parsed by Beeref #117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For example, running "pytest -l" will error out as Beeref would try to parse "-l" as a log level flag. Now we no longer try to blindly parse flags when including the Beeref commandline parser.
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #117 +/- ##
=======================================
Coverage 97.94% 97.94%
=======================================
Files 33 33
Lines 4376 4376
=======================================
Hits 4286 4286
Misses 90 90 ☔ View full report in Codecov by Sentry. |
In beeref/selection.py and beeref/view.py the commandline arg parse object would be created on import. Previously this would lead to the arg parse object being out of date when checking it. Now we don't recreate the arg parse helper object and instead make sure that it is static.
DarkDefender
force-pushed
the
fix_pytest_args
branch
from
45aadc1 to
3ba69d1
Compare
Contributor
Author
|
Just to clarify that the tests are passing on my machine at least. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example, running
pytest -lwill error out as Beeref would try to parse-las a log level flag. Now we no longer try to blindly parse flags when including the Beeref commandline parser.I ran into this when working on the other PR.