Skip to content

Docdiff: use pull request base branch for comparison #643

@agjohnson

Description

@agjohnson

Assuming we get the base branch from pull requests events on all of our provider integrations, we should be able to set the addons configuration for the docdiff base url on a pull request basis. This covers the use case of pull requests that have varying base branches and patterns like maintaining docs for multiple minor versions -- eg pull requests might base from a 1.x, 2.x, or 3.x branch.

We've discussed this in the past and there are some hurdles to implementing this, namely that the base branch might not be an active version. So at least we need to check for that and probably fall back to a version that is active. Are there other problems with this approach?

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions